Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine CAVScreen/ScreenView with SoccerScreen/View #152

Closed
samreid opened this issue Apr 22, 2023 · 2 comments
Closed

Combine CAVScreen/ScreenView with SoccerScreen/View #152

samreid opened this issue Apr 22, 2023 · 2 comments
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Apr 22, 2023

Now that there is no lab #1, should we combine CAVScreen/ScreenView and SoccerScreen/View, since everything is soccer now?
@samreid samreid added the dev:help-wanted Extra attention is needed label Apr 22, 2023
@samreid
Copy link
Member Author

samreid commented Apr 22, 2023

Likewise, it seems MeanOrMedianScreenView can be combined with those since all screens will use all those features.

samreid added a commit that referenced this issue Apr 25, 2023
@samreid
Separate card model to Median screen, see #152
f2592fc
samreid added a commit that referenced this issue Apr 25, 2023
@samreid
Separate median animation to MeanAndMedian model, see #152
0e0ca32
samreid added a commit that referenced this issue Apr 25, 2023
@samreid
Move MeanOrMedianScreenView.ts into SoccerScreenView.ts, see #152
8c193b3
samreid added a commit that referenced this issue Apr 25, 2023
@samreid
Move SoccerScreenView into CAVScreenView, see #152
43e6cff
samreid added a commit that referenced this issue Apr 25, 2023
@samreid
Move SoccerModel into CAVModel, see #152
189f4c6
samreid added a commit that referenced this issue Apr 25, 2023
@samreid
All data objects are soccer balls, see #152
b2a5d04
@samreid samreid mentioned this issue Apr 25, 2023
Closed
@samreid samreid self-assigned this Apr 25, 2023
@samreid samreid removed the dev:help-wanted Extra attention is needed label Apr 25, 2023
@samreid
Copy link
Member Author

samreid commented Apr 25, 2023

This is in good shape after the commits, closing.

@samreid samreid closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid