Remove isVariabilityScreen, see #153

phetsims · Apr 25, 2023 · 61ff9db · 61ff9db
1 parent b4012e4
commit 61ff9db
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/js/common/view/CAVScreenView.ts b/js/common/view/CAVScreenView.ts
@@ -43,7 +43,6 @@ import KickButtonGroup from './KickButtonGroup.js';
 type SelfOptions = {
   bottomCheckboxGroupOptions?: StrictOmit<BottomRepresentationCheckboxGroupOptions, 'tandem'>;
   questionBarOptions: QuestionBarOptions;
-  isVariabilityScreen: boolean;
 };
 
 export type CAVScreenViewOptions = SelfOptions & ScreenViewOptions;

diff --git a/js/mean-and-median/MeanAndMedianScreen.ts b/js/mean-and-median/MeanAndMedianScreen.ts
@@ -40,7 +40,6 @@ export default class MeanAndMedianScreen extends CAVScreen<MeanAndMedianModel, M
         dataPointFill: 'black'
       } ),
       model => new MeanAndMedianScreenView( model, {
-        isVariabilityScreen: false,
         tandem: options.tandem.createTandem( 'view' )
       } ),
       options

diff --git a/js/median/view/MedianScreenView.ts b/js/median/view/MedianScreenView.ts
@@ -25,14 +25,13 @@ import Tandem from '../../../../tandem/js/Tandem.js';
 type SelfOptions = EmptySelfOptions;
 type MedianScreenViewOptions =
   SelfOptions
-  & StrictOmit<CAVScreenViewOptions, 'isVariabilityScreen' | 'questionBarOptions'>;
+  & StrictOmit<CAVScreenViewOptions, 'questionBarOptions'>;
 
 export default class MedianScreenView extends CAVScreenView {
 
   public constructor( model: MedianModel, providedOptions: MedianScreenViewOptions ) {
 
     const options = optionize<MedianScreenViewOptions, SelfOptions, CAVScreenViewOptions>()( {
-      isVariabilityScreen: false,
       questionBarOptions: {
         barFill: CAVColors.medianQuestionBarFillColorProperty,
         questionString: CenterAndVariabilityStrings.medianQuestionStringProperty

diff --git a/js/variability/view/VariabilityScreenView.ts b/js/variability/view/VariabilityScreenView.ts
@@ -40,7 +40,7 @@ const TEXT_OPTIONS = {
 };
 
 type SelfOptions = EmptySelfOptions;
-type VariabilityScreenViewOptions = SelfOptions & StrictOmit<CAVScreenViewOptions, 'questionBarOptions' | 'isVariabilityScreen'>;
+type VariabilityScreenViewOptions = SelfOptions & StrictOmit<CAVScreenViewOptions, 'questionBarOptions'>;
 
 export default class VariabilityScreenView extends CAVScreenView {
 
@@ -55,7 +55,6 @@ export default class VariabilityScreenView extends CAVScreenView {
     const accordionBoxTitleProperty = new DynamicProperty<string, unknown, unknown>( currentProperty );
 
     const options = optionize<VariabilityScreenViewOptions, SelfOptions, CAVScreenViewOptions>()( {
-      isVariabilityScreen: true,
       questionBarOptions: {
         barFill: CAVColors.variabilityQuestionBarFillColorProperty,
         questionString: CenterAndVariabilityStrings.variabilityQuestionStringProperty