Dynamic locale doesn't localize element name

[oliver-phet]

This was reported by our Polish translator, but it appears to affect all locales.

Elements are translated properly in the Polish version of the sim, but not the all version(after dynamically switching locale).

May be related to #125 #90

[zepumph]

Thanks for reporting, and I'm sorry it took me so long to get to this. It looks like I totally omitted supporting dynamic locale with ShredStrings. It was easy enough to implement above, and now we can MR it into BAN 1.1. Thanks for your patience.

[zepumph]

QA: The bug was that the element name/identifier for a nuclide was not supporting dynamic local. You can see the bug here:

https://phet.colorado.edu/sims/html/build-a-nucleus/1.1.0/build-a-nucleus_all.html

Please make sure that switching the locale from the preferences menu updates the element name as well. Feel free to close.

[Nancy-Salpepi]

This looks fixed in 1.1.1-rc.1. Closing.

[zepumph]

@oliver-phet this is fixed in https://phet.colorado.edu/sims/html/build-a-nucleus/1.1.1/build-a-nucleus_all.html, but please note that caching will not show the update for 24 hours:

https://phet.colorado.edu/sims/html/build-a-nucleus/latest/build-a-nucleus_all.html

Please let the user know. Thanks.

[oliver-phet]

Thanks, translator notified!