Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations may need to be updated #125

Closed
Luisav1 opened this issue Aug 11, 2023 · 1 comment
Closed

Translations may need to be updated #125

Luisav1 opened this issue Aug 11, 2023 · 1 comment
Assignees
@zepumph

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 11, 2023 •
edited
Loading

Translations may need to be updated, using a script most likely as will be done here #76 (comment), since in the currently published version, the legend item strings in the Half-life Info dialog had the dash "-" which is now removed and done in the code instead. This fix was done for #76 in this commit 8cae8de.
This was found while doing the self code review in #112.
@Luisav1 Luisav1 mentioned this issue Aug 11, 2023
Closed
70 tasks
@zepumph zepumph mentioned this issue Aug 17, 2023
Closed
@zepumph
Copy link
Member

zepumph commented Aug 17, 2023

Thanks for reporting! This is important, and I definitely could have forgotten to clean this up. Thanks you! The script over in #76 (comment) will also fix this problem.

@zepumph zepumph closed this as completed Aug 17, 2023
@oliver-phet oliver-phet mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1