Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dynamic Locale #90

Closed
zepumph opened this issue Jul 6, 2023 · 3 comments
Closed

Support Dynamic Locale #90

zepumph opened this issue Jul 6, 2023 · 3 comments
Assignees
@zepumph
Labels
priority:2-high

Comments

@zepumph
Copy link
Member

zepumph commented Jul 6, 2023 •
edited
Loading

Decided in #89. This will involve:

  • Using i18n StringProperty instead of just the strings
  • Supporting dynamic layout in displayed texts.
  • testing with ?stringTest=dynamic + arrow keys
  • marking supportsDynamicLocale: true in the package
  • Using PatternStringProperty and DerivedStringProperty for patterns.
  • Probably something else!
@zepumph zepumph mentioned this issue Jul 6, 2023
Closed
@zepumph
Copy link
Member Author

zepumph commented Jul 21, 2023

Working on this now.

zepumph added a commit that referenced this issue Jul 21, 2023
@zepumph
convert from i18n strings -> i18n string Properties, #90
4557bdb
@zepumph zepumph mentioned this issue Jul 21, 2023
Closed
zepumph added a commit that referenced this issue Jul 21, 2023
@zepumph
dynamic locale adjustments to the "Available Decays" panel, #90
5bf9645
@zepumph zepumph mentioned this issue Jul 24, 2023
Closed
Luisav1 added a commit that referenced this issue Jul 26, 2023
@Luisav1
Use value of neutron string so it looks normal on the sim end. See #90.
ddd0207
zepumph added a commit that referenced this issue Jul 31, 2023
@zepumph
add maxWidth for full chart dialog, #90
83a0c86
zepumph added a commit to phetsims/scenery that referenced this issue Jul 31, 2023
@zepumph
don't assert out when using stringTest=dynamic on RichText links, phe…
05001ae 
…tsims/build-a-nucleus#90
@zepumph zepumph mentioned this issue Jul 31, 2023
Closed
zepumph added a commit that referenced this issue Jul 31, 2023
@zepumph
support dynamic locale for DecayScreenView, #90
a8badaf
zepumph added a commit to phetsims/babel that referenced this issue Jul 31, 2023
@zepumph
factor out updateElementName into a DerivedProperty that supports dyn…
6e73d24 
…amic locale, phetsims/build-a-nucleus#90
zepumph added a commit that referenced this issue Jul 31, 2023
@zepumph
updateElementName should not support layout, #90
03104f2
zepumph added a commit that referenced this issue Jul 31, 2023
@zepumph
factor out updateElementName into a DerivedProperty that supports dyn…
74f8279 
…amic locale, #90
zepumph added a commit that referenced this issue Jul 31, 2023
@zepumph
add support for dynamic layout on Chart Intro screen, #90
b2e9a1b
zepumph added a commit to phetsims/scenery that referenced this issue Jul 31, 2023
@zepumph
add support for dynamic layout on Chart Intro screen, phetsims/build-…
251b9f5 
…a-nucleus#90
@zepumph
Copy link
Member Author

zepumph commented Jul 31, 2023

I believe I have gotten all of this. I think the rest of dynamic layout will be caught by QA if there is anything. Before closing. I'd like to go over the changes to updateElementName in 74f8279. Then we will see if she would like to take a look at anything else before closing.

@zepumph
Copy link
Member Author

zepumph commented Jul 31, 2023

Discussed with @Luisav1, ready to close.

@zepumph zepumph closed this as completed Jul 31, 2023
This was referenced Aug 1, 2023
Closed
Closed
@oliver-phet oliver-phet mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1