Support dynamic locale for AtomIdentifier element name, phetsims/buil…

…d-a-nucleus#215
phetsims · Nov 16, 2023 · 301f869 · 301f869
1 parent a69214f
commit 301f869
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/js/make-isotopes/view/InteractiveIsotopeNode.js b/js/make-isotopes/view/InteractiveIsotopeNode.js
@@ -188,7 +188,7 @@ class InteractiveIsotopeNode extends Node {
       };
 
       // get element name and append mass number to identify isotope
-      let name = `${AtomIdentifier.getName( numProtons )}-${numProtons + numNeutrons}`;
+      let name = `${AtomIdentifier.getName( numProtons ).value}-${numProtons + numNeutrons}`;
       if ( name.length === 0 ) {
         name = '';
       }

diff --git a/js/make-isotopes/view/TwoItemPieChartNode.js b/js/make-isotopes/view/TwoItemPieChartNode.js
@@ -142,7 +142,7 @@ class TwoItemPieChartNode extends Node {
     // Attach otherIsotopeLabel with protonCountProperty to change element name on proton count change
     function updateOtherIsotopeLabel( isotope ) {
       const abundanceTo6Digits = AtomIdentifier.getNaturalAbundance( isotope, 6 );
-      const name = AtomIdentifier.getName( makeIsotopesModel.particleAtom.protonCountProperty.get() );
+      const name = AtomIdentifier.getName( makeIsotopesModel.particleAtom.protonCountProperty.get() ).value;
       if ( makeIsotopesModel.particleAtom.protonCountProperty.get() > 0 && abundanceTo6Digits < 1 ) {
         otherIsotopeLabel.string = StringUtils.format( otherIsotopesPatternString, name );
         otherIsotopeLabel.visible = true;

diff --git a/js/mix-isotopes/model/MixIsotopesModel.js b/js/mix-isotopes/model/MixIsotopesModel.js
@@ -498,7 +498,7 @@ class MixIsotopesModel {
     // Add the controllers.
     for ( let i = 0; i < this.possibleIsotopesProperty.get().length; i++ ) {
       const isotopeConfig = this.possibleIsotopesProperty.get()[ i ];
-      const isotopeCaption = `${AtomIdentifier.getName( isotopeConfig.protonCountProperty.get() )
+      const isotopeCaption = `${AtomIdentifier.getName( isotopeConfig.protonCountProperty.get() ).value
       }-${isotopeConfig.massNumberProperty.get()}`;
       if ( buckets ) {
         const newBucket = new MonoIsotopeBucket(