Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Expose WASM bulk memory extension in execution environment parameters #7008

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Expose WASM bulk memory extension in execution environment parameters #7008

merged 1 commit into from
Apr 5, 2023

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

Closes paritytech/substrate#6918

Why the other extensions are not exposed: paritytech/substrate#13811 (comment)
Why the Sign Extension Operators proposal is not exposed: paritytech/polkadot-sdk#15

@s0me0ne-unkn0wn s0me0ne-unkn0wn added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. labels Apr 5, 2023
mrcnski
mrcnski reviewed Apr 5, 2023
View reviewed changes
primitives/src/v4/executor_params.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is what is out now right? What happens if some nodes start using the new param and other nodes can't decode? IIRC it will throw an error but is it fatal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory yes, but in practice the array of params is hardcoded to be empty, hence safe to change

polkadot/runtime/parachains/src/session_info.rs

Lines 42 to 44 in dc230b3

// The order of parameters should be deterministic, that is, one should not reorder them when
// changing the array contents to avoid creating excessive pressure to PVF execution subsys.
const EXECUTOR_PARAMS: [ExecutorParam; 0] = [];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is what is out now right? What happens if some nodes start using the new param and other nodes can't decode? IIRC it will throw an error but is it fatal?

We've been discussing that for some time already, the last discussion was here: paritytech/substrate#13811 (comment).
In short, we won't bump the API version every time something changes in ExecutorParams. Instead, we allow validators with an old node implementation to fail to decode ExecutorParams, resulting in a no-show in pre-checking and execution. But we must be sure it doesn't result in a dispute.
For now, as @slumber correctly noted, we don't have a chance to fall into that situation as ExecutorParams are empty.

@s0me0ne-unkn0wn
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 26ff2cc into master Apr 5, 2023
@paritytech-processbot paritytech-processbot bot deleted the s0me0ne/wasm-features-eep branch April 5, 2023 22:01
ordian added a commit that referenced this pull request Apr 11, 2023
@ordian
Merge branch 'master' into ao-polkadot-enable-dispute-slashing
de707de 
* master: (28 commits)
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  Drop timers for new requests of active participations (#6974)
  Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981)
  Tighter bound on asset types teleported so that weight is cheaper (#6980)
  staking miner: less aggresive submissions (#6978)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
4f660d1 
* master: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
89a1a16 
…slashing-client

* ao-past-session-slashing-runtime: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slumber slumber slumber left review comments

@mrcnski mrcnski mrcnski left review comments

@bkchr bkchr bkchr approved these changes

@eskimor eskimor eskimor approved these changes

@koute koute Awaiting requested review from koute

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide blake2_512 in runtime or provide from_ss58check_with_version for runtime
5 participants
@s0me0ne-unkn0wn @eskimor @bkchr @mrcnski @slumber