Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

avoid triggering unwanted room_id for the release notifs #6984

Merged
merged 2 commits into from
Mar 31, 2023
Merged

avoid triggering unwanted room_id for the release notifs #6984

merged 2 commits into from
Mar 31, 2023

Conversation

armin-x86
Copy link
Contributor

@armin-x86 armin-x86 commented Mar 30, 2023 •
edited
Loading

Internal release-notes channel is not needed anymore and also new Matrix server is in place.

@armin-x86 armin-x86 requested review from a team and chevdor as code owners March 30, 2023 18:33
@paritytech-ci paritytech-ci requested a review from a team March 30, 2023 18:33
@paritytech-ci paritytech-ci requested a review from a team March 31, 2023 07:43
@alvicsam
Copy link
Contributor

A question out of curiosity: there are 3 more channels with matrix.parity.io. Shouldn't be they changed/removed as well?

@EgorPopelyaev
Copy link
Contributor

Shouldn't we have this kind of channel on the new server?

@armin-x86
Copy link
Contributor Author

Shouldn't we have this kind of channel on the new server?

"Internal release-notes channel" you mean? we have the polkadot/kusama announcements rooms.

A question out of curiosity: there are 3 more channels with matrix.parity.io. Shouldn't be they changed/removed as well?

You might be referring to :

  • #polkadot-announcements:matrix.parity.io
  • #kusama-announcements:matrix.parity.io
  • !NZrbtteFeqYKCUGQtr:matrix.parity.io (AliasName: #polkadotvalidatorlounge:web3.foundation )

They are copied to the new server and after the shutdown of the old server, they'll still are accessible.

➜  devops git:(master) ✗ curl -s -XGET -H "Authorization: Bearer $access_token" 'https://m.parity.io/_synapse/admin/v1/rooms/!NZrbtteFeqYKCUGQtr:matrix.parity.io' | jq
{
  "room_id": "!NZrbtteFeqYKCUGQtr:matrix.parity.io",
  "name": "Polkadot Validator Lounge",
  "canonical_alias": "#polkadotvalidatorlounge:web3.foundation",
  "joined_members": 10420,
  "joined_local_members": 43,
  "version": "1",
  "creator": "@thibaut_s:matrix.parity.io",
  "encryption": null,
  "federatable": true,
  "public": false,
  "join_rules": "public",
  "guest_access": "can_join",
  "history_visibility": "shared",
  "state_events": 10632,
  "avatar": "mxc://matrix.parity.io/YlmBlLMKaUDKMOkvaYBdurxz",
  "topic": "https://wiki.polkadot.network/docs/en/maintain-guides-how-to-validate-polkadot",
  "room_type": null,
  "joined_local_devices": 139,
  "forgotten": false
}

@EgorPopelyaev EgorPopelyaev added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 31, 2023
@EgorPopelyaev
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bb70b1d into master Mar 31, 2023
@paritytech-processbot paritytech-processbot bot deleted the unwanted-release-notification branch March 31, 2023 12:25
ordian added a commit that referenced this pull request Apr 11, 2023
@ordian
Merge branch 'master' into ao-polkadot-enable-dispute-slashing
de707de 
* master: (28 commits)
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  Drop timers for new requests of active participations (#6974)
  Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981)
  Tighter bound on asset types teleported so that weight is cheaper (#6980)
  staking miner: less aggresive submissions (#6978)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
4f660d1 
* master: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
89a1a16 
…slashing-client

* ao-past-session-slashing-runtime: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@alvicsam alvicsam alvicsam approved these changes

@chevdor chevdor Awaiting requested review from chevdor

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armin-x86 @alvicsam @EgorPopelyaev