This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
staking miner: less aggresive submissions #6978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have noticed that the staking-miner performs many concurrent RPC calls (more than 256). Probably because these batch request are getting bigger because the state is growing. So let's relax this and mine solutions sequentially i.e, mine solution one solution at the time and not in concurrently.
niklasad1
added
A0-please_review
niklasad1
commented
Mar 30, 2023
| @@ -131,6 +131,7 @@ impl SharedRpcClient { | |||
| .connection_timeout(connection_timeout) | |||
| .max_request_body_size(u32::MAX) | |||
| .request_timeout(request_timeout) | |||
| .max_concurrent_requests(u32::MAX as usize) | |||
kianenigma
approved these changes
Mar 30, 2023
gpestana
approved these changes
Mar 30, 2023
ordian
added a commit
that referenced
this pull request
Apr 11, 2023
* master: (28 commits) Remove years from copyright notes (#7034) Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013) PVF: Minor refactor in workers code (#7012) Expose WASM bulk memory extension in execution environment parameters (#7008) Co #13699: Remove old calls (#7003) Companion for paritytech/substrate#13811 (#6998) PR review rules, include all rs files except weights (#6990) Substrate companion: Remove deprecated batch verification (#6999) Added `origin` to config for `universal_origin` benchmark (#6986) Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993) Update Substrate to fix Substrate companions (#6994) Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458) Avoid redundant clone. (#6989) bump zombienet version (#6985) avoid triggering unwanted room_id for the release notifs (#6984) Add crowdloan to SafeCallFilter (#6903) Drop timers for new requests of active participations (#6974) Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981) Tighter bound on asset types teleported so that weight is cheaper (#6980) staking miner: less aggresive submissions (#6978) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that the staking-miner performs many concurrent RPC calls (more than 256). Probably these batch requests are getting bigger because the state is growing.
So let's relax this and mine solutions sequentially i.e, mine solution one solution at the time and not in concurrently.
This is similar to how staking-v2 does it as well