Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add crowdloan to SafeCallFilter #6903

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Add crowdloan to SafeCallFilter #6903

merged 4 commits into from
Mar 31, 2023

Conversation

hqwangningbo
Copy link
Contributor

@hqwangningbo hqwangningbo commented Mar 17, 2023 •
edited
Loading

Hello, members of the parity team.
We are the bifrost team, because of the version upgrade of polkadot-v0.9.38, the addition of SafeCallFilter has caused our SALP protocol to no longer be used.
The protocol has been running for a long time, and the protocol uses the Transact command to call crowdloan.
Want to know why crowdloan is not added to the list?
Hope to add crowdloan to the whitelist.

@ggwpez ggwpez requested a review from KiChjang March 17, 2023 13:18
@paritytech-ci paritytech-ci requested review from a team March 17, 2023 13:19
@hqwangningbo
Copy link
Contributor Author

@KiChjang Thank you for your review, these methods are enough for use now, I have modified the code.

@hqwangningbo
Copy link
Contributor Author

@KiChjang @ggwpez Can you help us with the process of merging?

@hqwangningbo
Copy link
Contributor Author

@KiChjang @ggwpez Please help me to set the labels. It seems that the pr check failed because the labels were not set.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 28, 2023
@hqwangningbo
Copy link
Contributor Author

@KiChjang @ggwpez I hope the parity team members can help to deal with it as soon as possible, sorry for the trouble 🙏

@KiChjang
Copy link
Contributor

This is now up to @paritytech/locks-review and @paritytech/polkadot-review, we can't really do much aside from pinging them again on reviewing this.

@hqwangningbo
Copy link
Contributor Author

@KiChjang I understand, how long does it usually take?

@paritytech-ci paritytech-ci requested a review from a team March 30, 2023 14:47
@ggwpez
Copy link
Member

ggwpez commented Mar 30, 2023

I understand, how long does it usually take?

It will get into the next release 😄

@hqwangningbo
Copy link
Contributor Author

@ggwpez @KiChjang @bkchr thanks for your work💗💗💗.

@ggwpez
Copy link
Member

ggwpez commented Mar 31, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ff7448f into paritytech:master Mar 31, 2023
ordian added a commit that referenced this pull request Apr 11, 2023
@ordian
Merge branch 'master' into ao-polkadot-enable-dispute-slashing
de707de 
* master: (28 commits)
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  Drop timers for new requests of active participations (#6974)
  Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981)
  Tighter bound on asset types teleported so that weight is cheaper (#6980)
  staking miner: less aggresive submissions (#6978)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
4f660d1 
* master: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
ordian added a commit that referenced this pull request Apr 12, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
89a1a16 
…slashing-client

* ao-past-session-slashing-runtime: (25 commits)
  [Deps] bump scale-info to be in line with cumulus (#7049)
  Invoke cargo build commands with `--locked` (#7057)
  use stable rust toolchain in ci
  apply clippy 1.68 suggestions
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@KiChjang KiChjang KiChjang approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hqwangningbo @KiChjang @ggwpez @andresilva @sam0x17 @bkchr