AO3-6553 Use div with a role rather than nav element #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two column layout breaks with nav because it relies on nth-of-type, which can't be used with a class as the sole selector.
sarken
added
Priority: High - Broken on Test
brianjaustin
approved these changes
Aug 16, 2023
ariana-paris
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6553
Purpose
The two column layout breaks when we switch to
navbecause it relies onnth-of-typeto apply styling to the odd-numbered modules. You can't do.class:nth-of-typewithout specifying an element (div), so things get complicated if we switch fromdivtonav.Testing Instructions
In addition to the original testing instructions, log in to an account with no favorite tags and ensure the layout on the homepage is normal.
References
#4581
alien originally asked if we could revert this because they have a lot on their plate, but when I realized what the issue was and asked if they'd mind me fixing it instead of reverting, they said it was fine.