AO3-6553 Use div with a role rather than nav element (#4608)

The two column layout breaks with nav because it relies on nth-of-type, which can't be used with a class as the sole selector.
otwcode · Aug 20, 2023 · 801ce09 · 801ce09
1 parent cb58c3a
commit 801ce09
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/views/home/index.html.erb b/app/views/home/index.html.erb
@@ -15,13 +15,13 @@
       </ul>
     </div>
   <% else %>
-    <nav aria-label="<%= t(".media_navigation_label") %>" class="browse module">
+    <div role="navigation" aria-label="<%= t(".media_navigation_label") %>" class="browse module">
       <h3 class="heading"><%= t(".find_your_favorites") %></h3>
       <% if logged_in? %>
         <p class="note"><%= t(".browse_or_favorite", count: ArchiveConfig.MAX_FAVORITE_TAGS) %></p>
       <% end %>
       <%= render 'fandoms' %>
-    </nav>
+    </div>
   <% end %>
 
   <% if @homepage.admin_posts.present? %>

diff --git a/public/stylesheets/site/2.0/26-media-narrow.css b/public/stylesheets/site/2.0/26-media-narrow.css
@@ -182,7 +182,7 @@ body .narrow-shown {
   padding: 0;
 }
 
-.splash div.module, .splash nav.module, .logged-in .splash div.module, .logged-in .splash nav.module {
+.splash div.module, .logged-in .splash div.module {
   clear: both;
   margin-left: 0;
   margin-right: 0;