Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6553 Use div with a role rather than nav element #4608

Merged
merged 1 commit into from
Aug 20, 2023
Merged

AO3-6553 Use div with a role rather than nav element #4608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/home/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
</ul>
</div>
<% else %>
<nav aria-label="<%= t(".media_navigation_label") %>" class="browse module">
<div role="navigation" aria-label="<%= t(".media_navigation_label") %>" class="browse module">
<h3 class="heading"><%= t(".find_your_favorites") %></h3>
<% if logged_in? %>
<p class="note"><%= t(".browse_or_favorite", count: ArchiveConfig.MAX_FAVORITE_TAGS) %></p>
<% end %>
<%= render 'fandoms' %>
</nav>
</div>
<% end %>

<% if @homepage.admin_posts.present? %>
Expand Down
2 changes: 1 addition & 1 deletion public/stylesheets/site/2.0/26-media-narrow.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ body .narrow-shown {
padding: 0;
}

.splash div.module, .splash nav.module, .logged-in .splash div.module, .logged-in .splash nav.module {
.splash div.module, .logged-in .splash div.module {
clear: both;
margin-left: 0;
margin-right: 0;
Expand Down