AO3-6058 Add 'translation into' to download preface #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
added
the
Priority: High - Broken on Test
brianjaustin
commented
Nov 4, 2023
ceithir
reviewed
Nov 4, 2023
| @@ -65,15 +65,24 @@ | |||
| <% end %> | |||
| <% end %> | |||
|
|
|||
| <%# i18n-tasks-use t("downloads.download_preface.translated_to.restricted_html") %> | |||
| <%# i18n-tasks-use t("downloads.download_preface.translated_to.revealed_html") %> | |||
| <%# i18n-tasks-use t("downloads.download_preface.translated_to.unrevealed_html") %> | |||
There was a problem hiding this comment.
Any particular reason these hints are within the template instead of in the helper where they're used?
There was a problem hiding this comment.
I had to think about it, but I think the reasoning is that the calls here "cause" the translation key to be used (i.e. without calling the helper here, the translation keys would be unused), and in contrast, the helper just "facilitates" the use
weeklies
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6058
Purpose
Add the translation(s) of a work to the links displayed at the beginning of a download.
Testing Instructions
Refer to Jira story
References
Follow-up to #4608
Credit
@weeklies for the majority of the work in the linked PR
Brian Austin (they/he)