Add spec for InfeedOp and OutfeedOp #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmako
changed the title
sdasgup3
force-pushed
the
spec-infeed-outfeed
branch
2 times, most recently
from
53b219d to
e0d3d15
Compare
subhankarshah
approved these changes
Dec 2, 2022
burmako
suggested changes
Dec 2, 2022
sdasgup3
force-pushed
the
spec-infeed-outfeed
branch
from
e0d3d15 to
009589f
Compare
sdasgup3
force-pushed
the
spec-infeed-outfeed
branch
from
009589f to
bef9e32
Compare
burmako
suggested changes
Dec 3, 2022
burmako
approved these changes
Dec 3, 2022
|
Merging without waiting for CI - the only CI-able change in the PR is documentation within the .td file. |
GleasonK
pushed a commit
to GleasonK/stablehlo
that referenced
this pull request
Dec 6, 2022
fixes openxla#525 verification of infeed op is revisit based on openxla#639 Note that for outfeed op we are using the output name as `results` based on the implicit name [introduced by the tablegen file](https://github.com/openxla/stablehlo/blob/dbf9964c6ce980e1976041700807bd94e6adf849/stablehlo/dialect/StablehloOps.td#L1030 ) even though it should be explicitly called out as `result` (singular). This will be addressed in openxla#351 (comment), item 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #525
verification of infeed op is revisit based on #639
Note that for outfeed op we are using the output name as
resultsbased on the implicit name introduced by the tablegen file even though it should be explicitly called out asresult(singular). This will be addressed in #351 (comment), item 4.