Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for InfeedOp/OutfeedOp #525

Closed
sdasgup3 opened this issue Nov 14, 2022 · 0 comments · Fixed by #640
Closed

Add spec for InfeedOp/OutfeedOp #525

sdasgup3 opened this issue Nov 14, 2022 · 0 comments · Fixed by #640
Assignees
@sdasgup3
Labels
Spec

Comments

@sdasgup3
Copy link
Member

sdasgup3 commented Nov 14, 2022 •
edited
Loading

Request description

To spec stablehlo.infeed and stablehlo.outfeed
@sdasgup3 sdasgup3 added the Spec label Nov 14, 2022
@sdasgup3 sdasgup3 self-assigned this Nov 14, 2022
@sdasgup3 sdasgup3 changed the title Add spec for InfeedOp Add spec for InfeedOp/OutfeedOp Nov 16, 2022
@sdasgup3 sdasgup3 mentioned this issue Nov 16, 2022
Closed
@sdasgup3 sdasgup3 mentioned this issue Nov 28, 2022
Merged
burmako pushed a commit that referenced this issue Dec 3, 2022
@sdasgup3
Add spec for InfeedOp and OutfeedOp (#640)
4fb042e 
fixes #525 

verification of infeed op is revisit based on
#639

Note that for outfeed op we are using the output name as `results` based
on the implicit name [introduced by the tablegen
file](https://github.com/openxla/stablehlo/blob/dbf9964c6ce980e1976041700807bd94e6adf849/stablehlo/dialect/StablehloOps.td#L1030
) even though it should be explicitly called out as `result` (singular).
This will be addressed in
#351 (comment),
item 4.
GleasonK pushed a commit to GleasonK/stablehlo that referenced this issue Dec 6, 2022
@sdasgup3 @GleasonK
Add spec for InfeedOp and OutfeedOp (openxla#640)
21f9454 
fixes openxla#525 

verification of infeed op is revisit based on
openxla#639

Note that for outfeed op we are using the output name as `results` based
on the implicit name [introduced by the tablegen
file](https://github.com/openxla/stablehlo/blob/dbf9964c6ce980e1976041700807bd94e6adf849/stablehlo/dialect/StablehloOps.td#L1030
) even though it should be explicitly called out as `result` (singular).
This will be addressed in
openxla#351 (comment),
item 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdasgup3 sdasgup3

Labels
Spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add spec for InfeedOp and OutfeedOp sdasgup3/stablehlo
1 participant
@sdasgup3