Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for CustomCallOp #636

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Add spec for CustomCallOp #636

merged 5 commits into from
Dec 13, 2022

Conversation

subhankarshah
Copy link
Member

closes #518

docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
Copy link
Member

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining feedbacks can be addressed with the next reviewer.

docs/spec_draft.md Outdated Show resolved Hide resolved
@ghpvnist ghpvnist assigned subhankarshah and unassigned ghpvnist Dec 8, 2022
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
docs/spec_draft.md Outdated Show resolved Hide resolved
@burmako burmako assigned subhankarshah and unassigned burmako Dec 11, 2022
@subhankarshah
Copy link
Member Author

@burmako removed layouts and output_operand_aliases from the spec, example and from constraints.

@burmako burmako assigned subhankarshah and unassigned burmako Dec 13, 2022
@burmako burmako merged commit 914ccd5 into openxla:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spec for CustomCallOp
4 participants