Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for SendOp and RecvOp #580

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Add spec for SendOp and RecvOp #580

merged 5 commits into from
Dec 2, 2022

Conversation

sdasgup3
Copy link
Member

@sdasgup3 sdasgup3 commented Nov 22, 2022 •
edited
Loading

fixes #527

verification is revisit on #579 and #667

@burmako burmako changed the title add spec for send/recv ops Add spec for SendOp and RecvOp Nov 22, 2022
@burmako burmako added the Spec label Nov 23, 2022
fschlimb
fschlimb reviewed Nov 28, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah reviewed Dec 1, 2022
View reviewed changes
docs/spec_draft.md Outdated Show resolved Hide resolved
subhankarshah
subhankarshah approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@subhankarshah subhankarshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some reword suggestions and a couple of comments, feel free to accept them, or keep them open if you decide against them.

@sdasgup3 sdasgup3 assigned burmako and subhankarshah and unassigned burmako and sdasgup3 Dec 2, 2022
subhankarshah
subhankarshah approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@subhankarshah subhankarshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdasgup3 sdasgup3 assigned burmako and unassigned sdasgup3 Dec 2, 2022
@sdasgup3 sdasgup3 requested a review from burmako December 2, 2022 21:26
@burmako burmako merged commit 8a2ce22 into openxla:main Dec 2, 2022
@burmako burmako assigned sdasgup3 and unassigned burmako Dec 2, 2022
@burmako burmako added the Migrate to MHLO PR that needs to be migrated to MLIR-HLO label Dec 4, 2022
GleasonK pushed a commit to GleasonK/stablehlo that referenced this pull request Dec 6, 2022
@sdasgup3 @GleasonK
Add spec for SendOp and RecvOp (openxla#580)
b93edc5 
fixes openxla#527 

verification is revisit on
openxla#579 and
openxla#667
@copybara-service copybara-service bot mentioned this pull request Dec 14, 2022
Closed
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
f37b67f 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495336100
@copybara-service copybara-service bot mentioned this pull request Dec 14, 2022
Merged
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
acd22c1 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495336100
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
79e8be0 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495336100
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
062f4c7 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495336100
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
ee92a6a 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495336100
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
ee1ad39 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495404149
copybara-service bot pushed a commit to tensorflow/mlir-hlo that referenced this pull request Dec 14, 2022
Port type inference for 6 ops from StableHLO to MHLO
fa4f213 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495404149
copybara-service bot pushed a commit to google/tsl that referenced this pull request Dec 14, 2022
@copybara-github
Port type inference for 6 ops from StableHLO to MHLO
4567fff 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495404149
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Dec 14, 2022
@copybara-github
Port type inference for 6 ops from StableHLO to MHLO
17b7002 
Ops:
  1) AfterAllOp: openxla/stablehlo#708.
  2) CreateTokenOp: openxla/stablehlo#711.
  3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
  4) OptimizationBarrierOp: openxla/stablehlo#575.
  5) OutfeedOp: openxla/stablehlo#713.
  6) SendOp: openxla/stablehlo#580.

This PR prepares for migration from producing MHLO to producing StableHLO by
aligning type inference between dialects, so that switching from one to another
doesn't need changes to calls to Python builders.

PiperOrigin-RevId: 495404149
MichaelHudgins pushed a commit to tensorflow/tensorflow that referenced this pull request Dec 14, 2022
@tensorflower-gardener @MichaelHudgins
Merged commit includes the following changes:
b517bde 
495413766  by A. Unique TensorFlower<[email protected]>:

    [xla:runtime] Encode constant scalar arguments as globals

--
495413735  by A. Unique TensorFlower<[email protected]>:

    Remove unused includes

--
495413388  by A. Unique TensorFlower<[email protected]>:

    Add SPMD expansion support for convolution backpropagation filter ops that use real filters rather than filter sizes.

--
495408634  by A. Unique TensorFlower<[email protected]>:

    Replace uses of tensorflow:macos with tensorflow/tsl:macos

--
495406952  by A. Unique TensorFlower<[email protected]>:

    Update TFRT dependency to use revision
    http://github.com/tensorflow/runtime/commit/bf7308dce2cdf05ba40f13aee258148db4483588.

--
495406613  by A. Unique TensorFlower<[email protected]>:

    [xla:runtime] Return individual arguments allocas from EncodeArguments

    Te be consistent with results encoding, arguments encoding should also return allocas for all arguments.

--
495404149  by A. Unique TensorFlower<[email protected]>:

    Port type inference for 6 ops from StableHLO to MHLO

    Ops:
      1) AfterAllOp: openxla/stablehlo#708.
      2) CreateTokenOp: openxla/stablehlo#711.
      3) DynamicUpdateSliceOp: openxla/stablehlo#686 and openxla/stablehlo#757.
      4) OptimizationBarrierOp: openxla/stablehlo#575.
      5) OutfeedOp: openxla/stablehlo#713.
      6) SendOp: openxla/stablehlo#580.

    This PR prepares for migration from producing MHLO to producing StableHLO by
    aligning type inference between dialects, so that switching from one to another
    doesn't need changes to calls to Python builders.

--
495401522  by A. Unique TensorFlower<[email protected]>:

    clean up mlir hlo builder test.
    Use existing helper function to check the hlo module.

--
495397939  by A. Unique TensorFlower<[email protected]>:

    Fix crash on malformed rank argument.

--
495396992  by A. Unique TensorFlower<[email protected]>:

    Some code cleanup

    - Fix `operator==` for NaN
    - Use default constructors
    - Use std::is_arithmetic_v over std::is_arithmetic

--
495395598  by A. Unique TensorFlower<[email protected]>:

    Export MLIR functions for XLA clusters, and add them to the function library.

--
495392602  by A. Unique TensorFlower<[email protected]>:

    [mhlo] Add input output aliasing in mhlo.fusion and provide import/export methods for HLO.

--
495382771  by A. Unique TensorFlower<[email protected]>:

    Introduce a MeshType struct for use in DTensor device C API to be used by Tensorflow Federated.

--
495381584  by A. Unique TensorFlower<[email protected]>:

    [IFRT] Change ifrt::Array to use intrusive reference counting.

    Pass and return Arrays by reference.

--

PiperOrigin-RevId: 495413766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhankarshah subhankarshah subhankarshah approved these changes

@fschlimb fschlimb fschlimb left review comments

@burmako burmako burmako approved these changes

Assignees

@sdasgup3 sdasgup3

Labels
Migrate to MHLO PR that needs to be migrated to MLIR-HLO Spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add spec for SendOp/RecvOp
5 participants
@sdasgup3 @fschlimb @burmako @subhankarshah @ghpvnist