-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX FE] Extend ONNX FE for operation GenerateProposals #12510
[ONNX FE] Extend ONNX FE for operation GenerateProposals #12510
Conversation
src/frontends/onnx/frontend/src/op/org.openvinotoolkit/generate_proposals.cpp
Outdated
Show resolved
Hide resolved
src/frontends/onnx/frontend/src/op/org.openvinotoolkit/generate_proposals.cpp
Outdated
Show resolved
Hide resolved
.. per review comments
@@ -3589,7 +3589,7 @@ template <element::Type_t ET> | |||
bool evaluate(const shared_ptr<op::v9::GenerateProposals>& op, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's not a question of this PR, but can we finally split this file into pieces? Currently, it takes too much time to compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - it's huge. I see two ways of such split:
- Split by chosen category (opset or operator). That implies splitting
docs/template_plugin/backend/opset_int_tbl.hpp
. - Create template declarations and move definitions into separate files. That implies template instantiations for each type and op combination in use.
src/frontends/onnx/frontend/src/op/org.openvinotoolkit/generate_proposals.cpp
Show resolved
Hide resolved
src/frontends/onnx/frontend/src/op/org.openvinotoolkit/generate_proposals.cpp
Outdated
Show resolved
Hide resolved
src/core/tests/models/onnx/org.openvinotoolkit/generate_proposals.prototxt
Outdated
Show resolved
Hide resolved
src/core/tests/models/onnx/org.openvinotoolkit/generate_proposals.prototxt
Outdated
Show resolved
Hide resolved
src/frontends/onnx/frontend/src/op/org.openvinotoolkit/generate_proposals.cpp
Show resolved
Hide resolved
src/frontends/onnx/frontend/src/op/org.openvinotoolkit/generate_proposals.cpp
Outdated
Show resolved
Hide resolved
correct values type in prototxt
Details:
Tickets:
79273