Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX FE] Extend ONNX FE for operation GenerateProposals #12510

Merged

Conversation

t-jankowski
Copy link
Contributor

Details:

  • Added GenerateProposals operator to ONNX FrontEnd

Tickets:

79273

@t-jankowski t-jankowski added the category: ONNX FE OpenVINO ONNX FrontEnd label Aug 11, 2022
@t-jankowski t-jankowski self-assigned this Aug 11, 2022
.. per review comments
@t-jankowski t-jankowski marked this pull request as ready for review August 11, 2022 13:35
@t-jankowski t-jankowski requested review from a team as code owners August 11, 2022 13:35
@@ -3589,7 +3589,7 @@ template <element::Type_t ET>
bool evaluate(const shared_ptr<op::v9::GenerateProposals>& op,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's not a question of this PR, but can we finally split this file into pieces? Currently, it takes too much time to compile

Copy link
Contributor Author

@t-jankowski t-jankowski Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - it's huge. I see two ways of such split:

  1. Split by chosen category (opset or operator). That implies splitting docs/template_plugin/backend/opset_int_tbl.hpp.
  2. Create template declarations and move definitions into separate files. That implies template instantiations for each type and op combination in use.

@mlukasze mlukasze enabled auto-merge (squash) August 17, 2022 11:33
@mlukasze mlukasze merged commit e24a5b8 into openvinotoolkit:master Aug 18, 2022
sgolebiewski-intel added a commit to sgolebiewski-intel/openvino_docs that referenced this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants