Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Extend ONNX Frontend with Function Celu-12 #20543

Closed
gkrivor opened this issue Oct 18, 2023 · 8 comments · Fixed by #22002
Closed

[Good First Issue]: Extend ONNX Frontend with Function Celu-12 #20543

gkrivor opened this issue Oct 18, 2023 · 8 comments · Fixed by #22002
Assignees
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers no_stale Do not mark as stale ONNX Related to support for ONNX standard.
Milestone

Comments

@gkrivor
Copy link
Contributor

gkrivor commented Oct 18, 2023

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.
OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.
This task requires extending OpenVINO ONNX Frontend with Function Celu.
Necessary help will be provided by ONNX Fronted team.

What needs to be done?

Operator details can be found in ONNX Operators
More details can be found in ONNX Changelog

  1. Create .hpp and .cpp files for *Windows here
  2. Prepare an implementation of this operator in form of a function. It should be placed in opset 1 namespace.
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here
  6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test".
    More details in adding operators to ONNX Frontend guide

Example Pull Requests

Resources

Contact points

@gkrivor

Ticket

No response

@gkrivor gkrivor added good first issue Good for newcomers category: ONNX FE OpenVINO ONNX FrontEnd no_stale Do not mark as stale labels Oct 18, 2023
@github-project-automation github-project-automation bot moved this to Contrubutors needed in Good first issues Oct 18, 2023
@p-wysocki p-wysocki moved this from Contrubutors needed to Assigned in Good first issues Oct 18, 2023
@ilya-lavrenov ilya-lavrenov moved this from Assigned to Contrubutors needed in Good first issues Oct 18, 2023
@p-wysocki p-wysocki moved this from Contrubutors needed to Assigned in Good first issues Oct 19, 2023
@ilya-lavrenov ilya-lavrenov moved this from Assigned to Contrubutors needed in Good first issues Oct 19, 2023
@mlukasze mlukasze added the ONNX Related to support for ONNX standard. label Oct 26, 2023
@sanbuphy
Copy link

sanbuphy commented Dec 7, 2023

Can i try this?

@ilya-lavrenov ilya-lavrenov moved this from Contributors Needed to Assigned in Good first issues Dec 7, 2023
@p-wysocki
Copy link
Contributor

Hello @sanbuphy, please let us know if you have any questions. :) You might find our work in progress contributor roadmap useful. If you do end up using it, please leave us some feedback!

@p-wysocki
Copy link
Contributor

Hello @sanbuphy, do you need any help?

Just yesterday our CONTRIBUTING.md has been updated with a technical guide - I highly recommend checking it out. :)

@siddhant-0707
Copy link
Contributor

.take
PR #22002

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to In Review in Good first issues Jan 8, 2024
@kshitij01042002
Copy link

Hi @siddhant-0707 are you still working on this issue? Please let me know if not I would like to take it up

@siddhant-0707
Copy link
Contributor

@kshitij01042002 as you can see from the mentioned PR, the issue is almost resolved, just needs a final review

@mitruska
Copy link
Contributor

Hello @siddhant-0707, thank you for your contribution.
I've requested changes in the PR #22002 related to the math formula of the Celu decomposition subgraph.
Please take a look at the latest review comments.

github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2024
### Details:
 - created implementation for `Celu-12` operator
 - created tests

### Tickets:
 - Closes #20543

---------

Co-authored-by: Andrei Kochin <[email protected]>
Co-authored-by: Georgy Krivoruchko <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Mar 5, 2024
@mlukasze mlukasze added this to the 2024.1 milestone Mar 5, 2024
Pranshu-S pushed a commit to Pranshu-S/openvino that referenced this issue Mar 7, 2024
…22002)

### Details:
 - created implementation for `Celu-12` operator
 - created tests

### Tickets:
 - Closes openvinotoolkit#20543

---------

Co-authored-by: Andrei Kochin <[email protected]>
Co-authored-by: Georgy Krivoruchko <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
alvoron pushed a commit to alvoron/openvino that referenced this issue Apr 29, 2024
…22002)

### Details:
 - created implementation for `Celu-12` operator
 - created tests

### Tickets:
 - Closes openvinotoolkit#20543

---------

Co-authored-by: Andrei Kochin <[email protected]>
Co-authored-by: Georgy Krivoruchko <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers no_stale Do not mark as stale ONNX Related to support for ONNX standard.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants