Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Extend ONNX Frontend with DeformConv operator #24649

Open
p-wysocki opened this issue May 23, 2024 · 11 comments
Open

[Good First Issue]: Extend ONNX Frontend with DeformConv operator #24649

p-wysocki opened this issue May 23, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers no_stale Do not mark as stale

Comments

@p-wysocki
Copy link
Contributor

p-wysocki commented May 23, 2024

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.

OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models. Usually the operator is already implemented in OpenVINO and ONNX Frontend serves as an API translation layer.

This task requires extending OpenVINO ONNX Frontend with DeformConv-19 operator.

Necessary help will be provided by ONNX Fronted team.

What needs to be done?

  1. Create .hpp and .cpp files for DeformConv here
  2. Prepare an implementation of this operator in form of a function. It should be placed in opset 1 namespace. You can use the implementation of standard ONNX Pad operator as a reference
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here

More details on adding operators to ONNX Frontend guide

Note: Since the only difference between DeformConv19 and DeformConv22 is new datatype, maybe ONNX can be expanded with both in the same PR?

Example Pull Requests

Resources

Contact points

@gkrivor
@p-wysocki
@mitruska

Ticket

CVS-119903

@Plomo-02
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues May 27, 2024
@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Jul 25, 2024
@nashez
Copy link
Contributor

nashez commented Jul 30, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Jul 30, 2024
@mlukasze
Copy link
Contributor

hey @nashez any help needed?

@nashez
Copy link
Contributor

nashez commented Sep 18, 2024

Hey @mlukasze
I will take this up once I am through with the couple of JIT Emitter issues assigned to me #24447 #24105 .

If this is more urgently needed, you can unassign me and if nobody has taken it up, I'll take this up again.

Thanks.

@mlukasze
Copy link
Contributor

we can wait, thanks :)

@nashez
Copy link
Contributor

nashez commented Dec 13, 2024

@p-wysocki @mlukasze I haven't been able to take this up so far and I have some other issues assigned that I might be able to finish first

Please unassign me from this issue and I will take it up if I have some free time

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Dec 13, 2024
@mlukasze
Copy link
Contributor

no worries, thanks for heads up!

@darksapien23151
Copy link
Contributor

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Assigned
Development

No branches or pull requests

5 participants