Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Extend ONNX Frontend with BitwiseNot-18 operator #20793

Closed
mitruska opened this issue Oct 31, 2023 · 6 comments · Fixed by #21872
Closed

[Good First Issue]: Extend ONNX Frontend with BitwiseNot-18 operator #20793

mitruska opened this issue Oct 31, 2023 · 6 comments · Fixed by #21872
Assignees
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers
Milestone

Comments

@mitruska
Copy link
Contributor

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.
OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.

This task requires extending OpenVINO ONNX Frontend with BitwiseNot operator, using the existing ov::op::v13::BitwiseNot.

Necessary help will be provided by ONNX Fronted team.

What needs to be done?

Operator details can be found in ONNX Operators
More details can be found in ONNX Changelog

  1. Create .hpp and .cpp files here
  2. Prepare an implementation of this operator in form of a function, bitwise_not should be placed in opset 1 namespace.
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here
  6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test".
    More details in adding operators to ONNX Frontend guide

Example Pull Requests

Resources

Contact points

@mitruska
@gkrivor
@p-wysocki

Ticket

118961

@rupeshs
Copy link
Contributor

rupeshs commented Dec 15, 2023

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues Dec 15, 2023
@p-wysocki
Copy link
Contributor

Hello @rupeshs! Thank you for taking a look, please let us know if you have any questions. Just yesterday our CONTRIBUTING.md has been updated with a technical guide - I highly recommend checking it out. :)

@rupeshs
Copy link
Contributor

rupeshs commented Dec 15, 2023

Hello @p-wysocki , created PR #21698

@mitruska mitruska moved this from Assigned to In Review in Good first issues Dec 15, 2023
@rupeshs
Copy link
Contributor

rupeshs commented Dec 26, 2023

Hi @gkrivor, @mitruska, Please ignore the previous PR.
New PR: #21872

@p-wysocki
Copy link
Contributor

Hello @rupeshs, sorry for the late reply - the holiday season just ended. We'll take a look at your PR as soon as possible, thank you for your contribution!

Also, I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

@mitruska mitruska linked a pull request Jan 8, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Jan 17, 2024
@mlukasze mlukasze added this to the 2024.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers
Projects
Archived in project
4 participants