-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Platform]: Variant page review #524
Conversation
* [Platform] Add Profile and ProfileHeader to variant page (#376) * [Platform]: variant page widgets init (#380) * draft pharmacokinetics widget (#383) * move reported protein link to description (#381) * [Platform] Add GWAS credible sets widget to variant page (#390) * [Platform] Add QTL credible sets widget to variant page (#396) * [Platform] Add Uniprot id to Uniprot description link (#401) * [Platform] Add allele frequency plot to variant page metadata section (#403) * frequency vis examples * polish plots * allele frequency bars * use flex for allele frequency plot * do not import grid * [Platform] Clean up variant page sections and summaries (#404) * [Platform] Update variant page QTL credible sets widget (#406) * [Platform] Use API for variant page header (#412) * [Platform] Correct dbXref link in variant page header (#414) * [Platform] Fix clinvar dbXref (#417) * [Platform] Use API for metadata in variant page (#420)
* [Platform] Add Profile and ProfileHeader to variant page (#376) * [Platform]: variant page widgets init (#380) * draft pharmacokinetics widget (#383) * move reported protein link to description (#381) * [Platform] Add GWAS credible sets widget to variant page (#390) * [Platform] Add QTL credible sets widget to variant page (#396) * [Platform] Add Uniprot id to Uniprot description link (#401) * [Platform] Add allele frequency plot to variant page metadata section (#403) * [Platform] Clean up variant page sections and summaries (#404) * [Platform] Update variant page QTL credible sets widget (#406) * [Platform] Use API for variant page header (#412) * [Platform] Correct dbXref link in variant page header (#414) * [Platform] Fix clinvar dbXref (#417) * [Platform] Use API for metadata in variant page (#420) * [Platform] Use API data for in silico predictors widget on variant page (#424) Co-authored-by: Carlos Cruz <[email protected]> * [Platform] Minor improvements to variant page insilico predictors widget (#429) * [Platform] Add VEP widget to variant page (#428)
* shorten variant ids in widget descriptions * avoid DOM nesting warnings
Co-authored-by: Carlos Cruz <[email protected]>
* add study table to study page * fix queries and fill in body * finish body * finish draft * column heading * link and column updates
* adapt allele frequency plot to order of magnitude * increase fixed width of right plot column
* add tooltips to posterior probability and r2 columns * study ID column labels
* include variants in search * update queries * comment VariantResults * include variants in search results page * add variant details * update info shown in search suggestions and results * make rsIds checks boolean * remove console.log * use divs to avoid MUI DOM nesting error * clean up variant search
* sort by exponent then mantissa * coloc fix
* fix: SharedTraitStudies * fix: study GWASCredibleSets * fix: study QTLCredibleSetsSection
--------- Co-authored-by: Carlos Cruz <[email protected]>
Some feedback. Feel free to decide what goes here and what goes in future PRs. There is a benefit on merging this the moment there is a favourable technical review, as it has a lot of good things and rescues the credible set widgets
Remember to add the condition to the molQTL table. It's a very easy change.
Also look at the sorting of the VEP widget which was originally missing from the spec |
There is a bug in the VEP widget: The Distance to Footprint column is incorrectly showing N/A when values are 0. Example page:
Let me know if this is a more widespread issue and we can open a ticket for it |
[Platform]: Variant page review
Description
Issue: opentargets/issues#3601 , opentargets/issues#3616
Deploy preview: https://deploy-preview-524--ot-platform-partner.netlify.app/
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: