[Platform]: Add ClinVar widget to variant page #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmehta
requested changes
Aug 29, 2024
| return sentenceCase(clinicalSignificances[0]); | ||
| } | ||
| return ( | ||
| <ul |
There was a problem hiding this comment.
why do we need ul and li tags here ? i can find example in preview link.
There was a problem hiding this comment.
I followed the approach in packages/sections/src/evidence/EVA. (See the preview with 15_90088702_C_T for an example with more than one significance on a row.)
There was a problem hiding this comment.
we can replace ul and li with Box as it will take care of showing element in next line.
| "" | ||
| )} | ||
| { | ||
| diseaseFromSource && |
There was a problem hiding this comment.
try simplifying this logic as well, avoid using nested conditions specially ternary operator.
There was a problem hiding this comment.
Simplified similar to above comments. Logic inside the tooltip is a little ugly but not sure alternatives are any cleaner?
chinmehta
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ClinVar widget to variant page.
Issue: #3318
Preview: https://deploy-preview-447--ot-platform.netlify.app/variant/4_1804392_G_A
Note: builds on PR #441.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checked on dev.
Checklist: