Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Display long variant ID appropriately in variant page header #433

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

gjmcn
Copy link
Contributor

@gjmcn gjmcn commented Aug 2, 2024

Description

For hashed ID, show shortened ID - when click on it, show both the hashed ID and the full ID.

If the ID is not hashed but still too long to show in the header, show shortened ID - when click it, show full ID.

Since full variant ID can be very long, implementation relies on a click event and a dialogue component (rather than a hover event and a popover).

Issue: #3390

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checked on dev. Example variant IDs (from short to long):

  • 19_10112623_C_T
  • OTVAR_12_54283979_209e9d0553810834370f743a4f1f554d
  • OTVAR_2_189001286_75a16febfb01d76c72337aa605d02e34

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

@carcruz carcruz merged commit f26325c into genetics Aug 6, 2024
11 checks passed
@carcruz carcruz deleted the gm-variant-name branch August 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants