remove creation of custom nova dataplane service #845
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ecc01653f0854b2a9db2448aa368960e ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 35m 48s |
|
check-rdo |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/2048c1e9dfa24dad8f54ecad9b826d79 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 18s |
The default nova dataplane service now supports an optional nova-extra-config configmap This change removes the creation of the custom service but keeps the creation fo the nova-extra-config configmap Depends-On: openstack-k8s-operators/dataplane-operator#920 Related: OSPRH-6407
SeanMooney
force-pushed
the
adapt-to-updated-nova-service-def
branch
from
8d06570 to
734c5aa
Compare
to break a ci depenency we need to carfully sequence our usage of dataSources. pr openstack-k8s-operators#846 broke the ablity for openstack-k8s-operators/dataplane-operator#920 to merge in the dataplane operator by hardcoding a replacement of the datasource in the nova dataplane service with only the custom config. as a result when we move the requried configmaps to the dataSources it overriedes them and resulting in ipam configution failing because the ssh key is not present. this change adapts install yamls to fully transfrom the dataplane service into the new form that will be intoduced in pr#920 then we can remove this temporay mesure once that is merged vai pr openstack-k8s-operators#845 Related: OSPRH-6407
|
im hoping that #851 will work allowing us to merge the dataplane change then this pr can be rebase to clean up once the depency cycle is broken |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4e9313de3942463fbf2111024ea285e7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 20s |
|
#851 does apeare to work so we have a path forward to merging : openstack-k8s-operators/dataplane-operator#920 assuming that now passes with the depends on. then when both are merged ill drop the hold form this pr |
|
addressed here #810 |
The default nova dataplane service now supports an optional
nova-extra-config configmap
This change removes the creation of the custom service
but keeps the creation fo the nova-extra-config configmap
Depends-On: openstack-k8s-operators/dataplane-operator#920
Related: OSPRH-6407