Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compat code for using datasouces #851

Conversation

SeanMooney
Copy link
Contributor

@SeanMooney SeanMooney commented Jun 11, 2024

to break a ci depenency we need to carfully sequence our usage
of dataSources.

pr #846 broke the ablity for
openstack-k8s-operators/dataplane-operator#920
to merge in the dataplane operator by hardcoding a replacement of the
datasource in the nova dataplane service with only the custom config.

as a result when we move the requried configmaps to the dataSources
it overriedes them and resulting in ipam configution failing because
the ssh key is not present.

this change adapts install yamls to fully transfrom the dataplane service
into the new form that will be intoduced in pr#920

then we can remove this temporay mesure once that is merged vai
pr #845

Related: OSPRH-6407

to break a ci depenency we need to carfully sequence our usage
of dataSources.

pr openstack-k8s-operators#846 broke the ablity for
openstack-k8s-operators/dataplane-operator#920
to merge in the dataplane operator by hardcoding a replacement of the
datasource in the nova dataplane service with only the custom config.

as a result when we move the requried configmaps to the dataSources
it overriedes them and resulting in ipam configution failing because
the ssh key is not present.

this change adapts install yamls to fully transfrom the dataplane service
into the new form that will be intoduced in pr#920

then we can remove this temporay mesure once that is merged vai
pr openstack-k8s-operators#845

Related: OSPRH-6407
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1e430c2 into openstack-k8s-operators:main Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants