Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy dataplane from openstack-operator #810

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Deploy dataplane from openstack-operator #810

merged 1 commit into from
Jun 14, 2024

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Apr 19, 2024 •
edited
Loading

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fao89
Copy link
Contributor Author

fao89 commented Apr 19, 2024

/test all

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/67d4ac38eea24cd4b3424936380651c6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 39s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 17m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 13s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 16m 13s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph SUCCESS in 2h 06m 43s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#765 is needed.

@fao89
Copy link
Contributor Author

fao89 commented Apr 20, 2024

recheck

@fao89
Copy link
Contributor Author

fao89 commented Apr 20, 2024

/test all

@fao89 fao89 mentioned this pull request Apr 20, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1e7736630af341e7b4f2fc07251b22f7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 11s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 23m 31s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 44s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 16m 07s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 04m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/57f3d1d0fad748dea56ddfab7b407ed7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 35m 46s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 25m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 48s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 14m 10s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 08m 32s

@fao89 fao89 closed this Apr 22, 2024
@fao89 fao89 reopened this Jun 4, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/install_yamls for 810,9f80bf49d82df3b24ad69479f700cb9dac5706a7

@fao89 fao89 force-pushed the mergedataplane branch from 9f80bf4 to cb25d2f Compare June 4, 2024 08:48
gibizer
gibizer reviewed Jun 4, 2024
View reviewed changes
Makefile
DATAPLANE_IMG ?= quay.io/openstack-k8s-operators/dataplane-operator-index:${OPENSTACK_K8S_TAG}
DATAPLANE_REPO ?= https://github.com/openstack-k8s-operators/dataplane-operator.git
DATAPLANE_BRANCH ?= ${OPENSTACK_K8S_BRANCH}
DATAPLANE_COMMIT_HASH ?=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are couple of hits in ci-framework to these env vars. I'm not sure if that is active framework code or just some ci-framework self testing code https://github.com/search?q=repo%3Aopenstack-k8s-operators%2Fci-framework%20DATAPLANE_IMG&type=code

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f337e0e175784c649dad494df1dd9722

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 49s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 48m 55s
❌ podified-multinode-edpm-deployment-crc FAILURE in 46m 05s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 55m 15s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 1h 42m 34s

fao89 added a commit to fao89/ci-framework that referenced this pull request Jun 4, 2024
@fao89
Drop unused dataplane vars
fb23c58 
ref:
- openstack-k8s-operators/install_yamls#810
- openstack-k8s-operators/openstack-operator#765

Signed-off-by: Fabricio Aguiar <[email protected]>
@fao89 fao89 mentioned this pull request Jun 4, 2024
Merged
4 tasks
@fao89 fao89 force-pushed the mergedataplane branch from cb25d2f to 02daaaf Compare June 7, 2024 20:37
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/87bfa446edfd498dae83a0d77e8c101c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 43m 02s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 41m 42s
❌ podified-multinode-edpm-deployment-crc FAILURE in 36m 00s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 27m 34s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph SUCCESS in 2h 24m 35s

@fao89 fao89 force-pushed the mergedataplane branch 3 times, most recently from d20b315 to dfda0e5 Compare June 11, 2024 20:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/46d682fe17b346f2b2ea71ebcef472d6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 39s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 42m 02s
❌ podified-multinode-edpm-deployment-crc FAILURE in 40m 15s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 09m 37s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph RETRY_LIMIT in 11m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e302b547b512401abb28fcbf99d497c2

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 28s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 46m 37s
❌ podified-multinode-edpm-deployment-crc FAILURE in 40m 24s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 09m 11s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 07m 31s

@bshephar bshephar mentioned this pull request Jun 13, 2024
Merged
rabi
rabi reviewed Jun 13, 2024
View reviewed changes
Makefile Outdated
@@ -2123,13 +2115,13 @@ baremetal_cleanup: ## deletes the operator, but does not cleanup the service res

##@ DATAPLANE
.PHONY: dataplane_prep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need these targets as dataplane kuttl tests already use openstack target.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a118de77de234c47a52bce659fccadbf

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 19s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 46m 21s
❌ podified-multinode-edpm-deployment-crc FAILURE in 36m 47s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 30m 41s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph SUCCESS in 2h 26m 15s

@fao89 fao89 marked this pull request as ready for review June 13, 2024 21:43
@openshift-ci openshift-ci bot requested review from dprince and olliewalsh June 13, 2024 21:43
@rabi
Copy link
Contributor

rabi commented Jun 14, 2024

recheck

rabi
rabi reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2024
@rabi rabi mentioned this pull request Jun 14, 2024
Closed
@openshift-merge-bot openshift-merge-bot bot merged commit dca1e94 into openstack-k8s-operators:main Jun 14, 2024
5 checks passed
@fao89 fao89 mentioned this pull request Jun 14, 2024
Closed
fao89 added a commit to fao89/ci-framework that referenced this pull request Jun 14, 2024
@fao89
Drop unused dataplane vars
1d4fe22 
ref:
- openstack-k8s-operators/install_yamls#810
- openstack-k8s-operators/openstack-operator#765

Signed-off-by: Fabricio Aguiar <[email protected]>
fao89 added a commit to fao89/ci-framework that referenced this pull request Jun 14, 2024
@fao89
Drop unused dataplane vars
f06fff1 
ref:
- openstack-k8s-operators/install_yamls#810
- openstack-k8s-operators/openstack-operator#765

Signed-off-by: Fabricio Aguiar <[email protected]>
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/ci-framework that referenced this pull request Jun 18, 2024
@fao89 @openshift-merge-bot
Drop unused dataplane vars
73170de 
ref:
- openstack-k8s-operators/install_yamls#810
- openstack-k8s-operators/openstack-operator#765

Signed-off-by: Fabricio Aguiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibizer gibizer gibizer left review comments

@rabi rabi rabi left review comments

@dprince dprince Awaiting requested review from dprince

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@rabi rabi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fao89 @rabi @gibizer @openshift-merge-robot