V0.1.31 rebase master #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes-retired#2296) When validation of Broker.Spec.CatalogRestrictions.ServicePlan failed, spec.CatalogRestrictions.ServiceClass was passed as the bad value in the validation error. It should be spec.CatalogRestrictions.ServicePlan.
…lds (kubernetes-retired#2311) The admission control plugin now validates if the fields being selected in broker.spec.catalogRestrictions are on the approved list or not.
…ernetes-retired#2300) The order did not match the one in v1beta1/types.go, leading to an incorrect conversion between the two types.
* support for headless services (Type:clusterIP;clusterIP:None). In addiiton this feature also allow to use userdefined clusterIp type service, where user can specify the IP or let Kubernetes choose an IP. * changed clusterIp -> clusterIP fixed a typo.
* Run validation subtests with testing.Run() * Don't print testcase name in error message
svcat only support register now, deregister is added to support remove broker registered.
…tired#2312) When the clusterserviceclass controller reconciles the key, the value should be like 'class' not 'plan'.
…red#2316) Question marks are not allowed in filenames on windows.
* modify the doc format * modify trailing
* Add namespace flags to get plans * Fix unit tests * Add "Namespace" column to Plans table output
…tes-retired#2293) * svcat deprovision - wait for instance to not exist vs change status * remove dead test case, clean up error handling
…ubernetes-retired#2313) * Use controller's default brokerRelistInterval for namespaced brokers * Refactor shouldReconcile(Cluster)ServiceBroker into a single function The two functions only relied on common components. * Remove duplicated code in getTestClusterServiceBrokerWithStatus * Run subtests with testing.Run() * Add test where relistDuration is nil and interval has elapsed
Merge executed via ./UPSTREAM-MERGE.sh v0.1.31 upstream master Overwritten conflicts: <NONE>
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
|
/test service-catalog |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(tag: v0.1.31, upstream/master) Bump version 0.1.31 (kubernetes-retired#2324)
Use controller's default brokerRelistInterval for namespaced brokers (kubernetes-retired#2313)
svcat deprovision --wait doesn't work properly in some cases (kubernetes-retired#2293)
Add namespace flags to get plans (kubernetes-retired#2285)
modify the document format (kubernetes-retired#2320)
Escape question mark character in testdata filenames (kubernetes-retired#2316)
Fix variable name in reconcileClusterServiceClassKey() (kubernetes-retired#2312)
Add deregister command in svcat (kubernetes-retired#2314)
Run validation subtests with testing.Run() (kubernetes-retired#2297)
Rename PR_TEMPLATE.md to PULL_REQUEST_TEMPLATE.md (kubernetes-retired#2317)
support for headless services for API server (kubernetes-retired#2304)
Fix field order in CatalogRestriction in servicecatalog/types.go (kubernetes-retired#2300)
Reject ServiceBrokers whose catalogRestrictions reference invalid fields (kubernetes-retired#2311)
Fix validation error's bad value (ServicePlan instead of ServiceClass) (kubernetes-retired#2296)
Remove regex validation of service class external IDs (kubernetes-retired#2303)