Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Fix validation error's bad value (ServicePlan instead of ServiceClass) #2296

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Aug 27, 2018

When validation of Broker.Spec.CatalogRestrictions.ServicePlan failed,
spec.CatalogRestrictions.ServiceClass was passed as the bad value in
the validation error. It should be spec.CatalogRestrictions.ServicePlan.

When validation of Broker.Spec.CatalogRestrictions.ServicePlan failed,
spec.CatalogRestrictions.ServiceClass was passed as the bad value in
the validation error. It should be spec.CatalogRestrictions.ServicePlan.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented Aug 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2018
@jeremyrickard
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyrickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2d1765e into kubernetes-retired:master Aug 29, 2018
@luksa luksa deleted the validation_fix branch August 29, 2018 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants