This repository has been archived by the owner on May 6, 2022. It is now read-only.
support for headless services for API server #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iiton this feature also allow to use userdefined clusterIp type service, where user can specify the IP or let Kubernetes choose an IP.
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
needs-ok-to-test
|
/assign @pmorie |
nilebox
reviewed
Aug 30, 2018
charts/catalog/README.md
Outdated
| @@ -48,8 +48,9 @@ chart and their default values. | |||
| | `apiserver.aggregator.groupPriorityMinimum` | The minimum priority the group should have. | `10000` | | |||
| | `apiserver.aggregator.versionPriority` | The ordering of this API inside of the group | `20` | | |||
| | `apiserver.tls.requestHeaderCA` | Base64-encoded CA used to validate request-header authentication, when receiving delegated authentication from an aggregator. If not set, the service catalog API server will inherit this CA from the `extension-apiserver-authentication` ConfigMap if available. | `nil` | | |||
| | `apiserver.service.type` | Type of service; valid values are `LoadBalancer` and `NodePort` | `NodePort` | | |||
| | `apiserver.service.type` | Type of service; valid values are `LoadBalancer` and `NodePort` and `ClusterIP` | `NodePort` | | |||
There was a problem hiding this comment.
Change to "... LoadBalancer, NodePort and ClusterIP ... "
(you have "and" twice in the sentence enumerating types)
| @@ -9,6 +9,11 @@ metadata: | |||
| heritage: "{{ .Release.Service }}" | |||
| spec: | |||
| type: {{ .Values.apiserver.service.type }} | |||
| {{- if eq .Values.apiserver.service.type "ClusterIP" }} | |||
| {{- if .Values.apiserver.service.clusterIp }} | |||
There was a problem hiding this comment.
please change clusterIp -> clusterIP everywhere
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
fixed a typo.
|
Thanks for review @nilebox. Pushed the suggested changes. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for headless services for API server (Type:clusterIP;clusterIP:None). In additon this feature also allow to use userdefined clusterIp type service, where user can specify the IP or let Kubernetes choose an IP.
In some scenarios API server can work with headless services.