Add deregister command in svcat

[jichenjc]

svcat only support register now, deregister is added to support
remove broker registered.

[luksa]

/ok-to-test

[luksa]

@jichenjc You need to run make test-update-goldenfiles.

[jichenjc]

I run make test golden configuration and encoutner weird issue locally, submit to CI for double check

[luksa]

Looks like you committed something you didn't want to :)

[luksa]

@jichenjc Yeah, I saw the same issue when I ran make locally, too. Looks like it's not a real issue at all.

/lgtm

[luksa]

/lgtm cancel

Actually, @jichenjc can you add a deregister broker test to TestCommandOutput() in svcat_test.go. Make sure to include a newline at the end of output/deregister-broker.txt and you'll see that the command doesn't add the newline:

[luksa@w541 service-catalog]$ svcat deregister ups-broker
Successfully removed broker "ups-broker"[luksa@w541 service-catalog]$ 

Can you also please fix that? I'd fix it myself, but I can't until this PR is merged, so you might as well do it here.

[jichenjc]

ok, I will fix it soon by adding the test and the new line, thanks for the reminder

[jichenjc]

root@kvm-016922:/go/src/github.com/kubernetes-incubator/service-catalog# bin/svcat/svcat get brokers
NAME NAMESPACE URL STATUS
+--------------+-----------+------------------------------------------------+----------------------+
nasty-broker http://nasty-service.default.svc.cluster.local ErrorFetchingCatalog
root@kvm-016922:/go/src/github.com/kubernetes-incubator/service-catalog# bin/svcat/svcat deregister nasty-broker
Successfully removed broker "nasty-broker"

should be fine now :)

[luksa]

/lgtm

[jboyd01]

This looks good for Cluster service brokers but lacks support & tests for Name Spaced brokers. We can do that in a followup. @jichenjc do you have any interest in doing that next? :)
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/svcat/OWNERS [jboyd01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jichenjc]

yes, I will create another issue and PR to fix the namespace followup, thanks for the reminder