Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] A rule flyout without references have an empty link #521

Closed
jovancacvetkovic opened this issue Apr 17, 2023 · 0 comments · Fixed by #525
Closed

[BUG] A rule flyout without references have an empty link #521

jovancacvetkovic opened this issue Apr 17, 2023 · 0 comments · Fixed by #525
Labels
bug Something isn't working untriaged

Comments

@jovancacvetkovic
Copy link

jovancacvetkovic commented Apr 17, 2023

What is the bug?
A rule flyout without references has an empty link.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Create a rule without references
  2. Go to rules
  3. Open rule flyout
  4. Note the references link icon

What is the expected behavior?
There should be no link if there are no references set

Do you have any screenshots?
rule without references still have a link

@jovancacvetkovic jovancacvetkovic added bug Something isn't working untriaged labels Apr 17, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 17, 2023
…arch-project#522

[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 17, 2023
…arch-project#522

[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 17, 2023
…arch-project#522

[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 18, 2023
…arch-project#522

[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit that referenced this issue Apr 18, 2023
* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 18, 2023
* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit f1be08e)
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 18, 2023
* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit f1be08e)
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Apr 18, 2023
* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt added a commit that referenced this issue Apr 18, 2023
* Minor bug fixes (#505)

* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* [BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515)

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 18, 2023
* Minor bug fixes (#505)

* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* [BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515)

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit d0b1702)
AWSHurneyt added a commit that referenced this issue Apr 18, 2023
* Minor bug fixes (#505)

* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* [BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515)

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit d0b1702)

Co-authored-by: AWSHurneyt <[email protected]>
amsiglan added a commit that referenced this issue May 4, 2023
* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page #471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 5, 2023
* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 5, 2023
* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this issue May 5, 2023
…577)

* [BUG] Finding's fly-out has no correlations if open from alerts (#558)

* [BUG] Finding's fly-out has no correlations if open from alerts #557

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review from #558 (comment)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress | create detector specs update (#518)

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page #471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>

* added link to rules; simplified rule parsing (#571)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* [FEATURE] Finding flyout loading state (#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready #559

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 (#565)

* Add correlation rule details into the finding details flyout #563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* UX improvements for correlation engine (#561)

* passing props for date time filter (#551)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added loading state

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Add a details button to open the findings flyout from the correlations page. (#572)

* Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Wrong field mappings for the cloud trail logs (#574)

* Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
* Minor bug fixes (opensearch-project#505)

* [BUG] Edit details Save button should be blue opensearch-project#499

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* [BUG] Fixes few minor UX bugs (opensearch-project#525)

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (opensearch-project#515)

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
…pensearch-project#577)

* [BUG] Finding's fly-out has no correlations if open from alerts (opensearch-project#558)

* [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review from opensearch-project#558 (comment)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress | create detector specs update (opensearch-project#518)

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>

* added link to rules; simplified rule parsing (opensearch-project#571)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* [FEATURE] Finding flyout loading state (opensearch-project#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 (opensearch-project#565)

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* UX improvements for correlation engine (opensearch-project#561)

* passing props for date time filter (opensearch-project#551)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added loading state

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Add a details button to open the findings flyout from the correlations page. (opensearch-project#572)

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Wrong field mappings for the cloud trail logs (opensearch-project#574)

* Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant