Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a details button to open the findings flyout from the correlations page. #572

Conversation

jovancacvetkovic
Copy link

Description

Add a details button to open the findings flyout from the correlations page.

Issues Resolved

Resolves #564

Screenshots

235093541-baf69562-02ee-49d7-be65-b5e0363f13d4

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-analytics-dashboards-plugin into Add_a_details_button_to_open_the_findings_flyout_from_the_correlations_page
…-analytics-dashboards-plugin into Add_a_details_button_to_open_the_findings_flyout_from_the_correlations_page

# Conflicts:
#	public/pages/Alerts/components/AlertFlyout/AlertFlyout.tsx
#	public/pages/Findings/components/FindingDetailsFlyout.tsx
#	public/pages/Findings/components/FindingsTable/FindingsTable.tsx
#	public/store/DataStore.ts
@jovancacvetkovic jovancacvetkovic requested a review from a team May 4, 2023 09:33
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #572 (f1c87fb) into main (d9aa818) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   32.47%   32.45%   -0.03%     
==========================================
  Files         137      137              
  Lines        4105     4117      +12     
  Branches      671      673       +2     
==========================================
+ Hits         1333     1336       +3     
- Misses       2632     2642      +10     
+ Partials      140      139       -1     

see 14 files with indirect coverage changes

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into Add_a_details_button_to_open_the_findings_flyout_from_the_correlations_page

# Conflicts:
#	public/app.scss
#	public/pages/Correlations/containers/CorrelationsContainer.tsx
#	public/pages/Findings/components/FindingDetailsFlyout.tsx
#	public/store/CorrelationsStore.ts
Signed-off-by: Jovan Cvetkovic <[email protected]>
@amsiglan amsiglan merged commit 01c3266 into opensearch-project:main May 4, 2023
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request May 5, 2023
…s page. (opensearch-project#572)

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan added a commit that referenced this pull request May 5, 2023
…577)

* [BUG] Finding's fly-out has no correlations if open from alerts (#558)

* [BUG] Finding's fly-out has no correlations if open from alerts #557

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review from #558 (comment)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress | create detector specs update (#518)

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page #471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>

* added link to rules; simplified rule parsing (#571)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* [FEATURE] Finding flyout loading state (#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready #559

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 (#565)

* Add correlation rule details into the finding details flyout #563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* UX improvements for correlation engine (#561)

* passing props for date time filter (#551)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added loading state

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Add a details button to open the findings flyout from the correlations page. (#572)

* Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Wrong field mappings for the cloud trail logs (#574)

* Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…pensearch-project#577)

* [BUG] Finding's fly-out has no correlations if open from alerts (opensearch-project#558)

* [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review from opensearch-project#558 (comment)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress | create detector specs update (opensearch-project#518)

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>

* added link to rules; simplified rule parsing (opensearch-project#571)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* [FEATURE] Finding flyout loading state (opensearch-project#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 (opensearch-project#565)

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* UX improvements for correlation engine (opensearch-project#561)

* passing props for date time filter (opensearch-project#551)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added loading state

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Add a details button to open the findings flyout from the correlations page. (opensearch-project#572)

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <[email protected]>

* fix tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Wrong field mappings for the cloud trail logs (opensearch-project#574)

* Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a details button to open the findings flyout from the correlations page.
5 participants