[BUG] Finding's fly-out has no correlations if open from alerts #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-project#557 Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
reviewed
Apr 26, 2023
AWSHurneyt
approved these changes
Apr 26, 2023
amsiglan
reviewed
Apr 26, 2023
…-analytics-dashboards-plugin into findings_flyout_correlations_bug
Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into findings_flyout_correlations_bug
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 32.66% 32.70% +0.04%
==========================================
Files 135 136 +1
Lines 4020 4048 +28
Branches 649 652 +3
==========================================
+ Hits 1313 1324 +11
- Misses 2567 2584 +17
Partials 140 140 |
jovancacvetkovic
changed the title
amsiglan
approved these changes
May 3, 2023
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
|
Failing test is flaky and passed for windows runner |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 3, 2023
* [BUG] Finding's fly-out has no correlations if open from alerts #557 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review from #558 (comment) Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 28edd8e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 5, 2023
* [BUG] Finding's fly-out has no correlations if open from alerts #557 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review from #558 (comment) Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit 28edd8e)
amsiglan
pushed a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
May 5, 2023
…search-project#558) * [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review from opensearch-project#558 (comment) Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
1 task
amsiglan
added a commit
that referenced
this pull request
May 5, 2023
…577) * [BUG] Finding's fly-out has no correlations if open from alerts (#558) * [BUG] Finding's fly-out has no correlations if open from alerts #557 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review from #558 (comment) Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress | create detector specs update (#518) * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Provide empty states for Findings and Alerts page #471 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] update detector details component #504 Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] update detector details component #504 Signed-off-by: Jovan Cvetkovic <[email protected]> * Update detector details component #504 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <[email protected]> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> * added link to rules; simplified rule parsing (#571) Signed-off-by: Amardeepsingh Siglani <[email protected]> * [FEATURE] Finding flyout loading state (#562) * [FEATURE] Set loading state for finding fly-out until the data is ready #559 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout #563 (#565) * Add correlation rule details into the finding details flyout #563 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout #563 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout #563 #565 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout #563 #565 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout #563 #565 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * UX improvements for correlation engine (#561) * passing props for date time filter (#551) Signed-off-by: Amardeepsingh Siglani <[email protected]> * added loading state Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux improvements Signed-off-by: Amardeepsingh Siglani <[email protected]> * transform vega-lite files for jest testing Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * Add a details button to open the findings flyout from the correlations page. (#572) * Add a details button to open the findings flyout from the correlations page. #564 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add a details button to open the findings flyout from the correlations page. #564 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add a details button to open the findings flyout from the correlations page. #564 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Wrong field mappings for the cloud trail logs (#574) * Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * updated workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated osd branch for cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…pensearch-project#577) * [BUG] Finding's fly-out has no correlations if open from alerts (opensearch-project#558) * [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review from opensearch-project#558 (comment) Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress | create detector specs update (opensearch-project#518) * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <[email protected]> * Feature] update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <[email protected]> * Update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <[email protected]> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <[email protected]> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> * added link to rules; simplified rule parsing (opensearch-project#571) Signed-off-by: Amardeepsingh Siglani <[email protected]> * [FEATURE] Finding flyout loading state (opensearch-project#562) * [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout opensearch-project#563 (opensearch-project#565) * Add correlation rule details into the finding details flyout opensearch-project#563 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout opensearch-project#563 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * UX improvements for correlation engine (opensearch-project#561) * passing props for date time filter (opensearch-project#551) Signed-off-by: Amardeepsingh Siglani <[email protected]> * added loading state Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux improvements Signed-off-by: Amardeepsingh Siglani <[email protected]> * transform vega-lite files for jest testing Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * Add a details button to open the findings flyout from the correlations page. (opensearch-project#572) * Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <[email protected]> * Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <[email protected]> * fix tests Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * Wrong field mappings for the cloud trail logs (opensearch-project#574) * Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> * code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * updated workflow file Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated osd branch for cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing finding's fly-out has no correlations if open from the alerts page.
Issues Resolved
Resolves #557
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.