[BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-project · Apr 18, 2023 · f1be08e · f1be08e
1 parent 88bed3e
commit f1be08e
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/cypress/integration/2_rules.spec.js b/cypress/integration/2_rules.spec.js
@@ -169,6 +169,7 @@ describe('Rules', () => {
     );
 
     // Enter the reference
+    cy.contains('Add another URL').click();
     cy.get('[data-test-subj="rule_references_field_0"]').type(SAMPLE_RULE.references);
 
     // Enter the false positive cases

diff --git a/...ages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx b/...ages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx
@@ -253,7 +253,7 @@ export default class ConfigureFieldMapping extends Component<
             <EuiAccordion
               buttonContent={
                 <div data-test-subj="mapped-fields-btn">
-                  <EuiTitle>
+                  <EuiTitle size={'s'}>
                     <h6>{`Automatically mapped fields (${mappedRuleFields.length})`}</h6>
                   </EuiTitle>
                 </div>
@@ -303,7 +303,7 @@ export default class ConfigureFieldMapping extends Component<
 
                   <EuiSpacer size={'m'} />
 
-                  <EuiTitle>
+                  <EuiTitle size={'s'}>
                     <h6>Pending field mappings</h6>
                   </EuiTitle>
                   <FieldMappingsTable<MappingViewType.Edit>

diff --git a/...ges/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx b/...ges/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx
@@ -92,7 +92,7 @@ export const DetectionRules: React.FC<DetectionRulesProps> = ({
       <EuiAccordion
         buttonContent={
           <div data-test-subj="detection-rules-btn">
-            <EuiTitle>
+            <EuiTitle size={'s'}>
               <h4>{`Detection rules (${enabledRulesCount} selected)`}</h4>
             </EuiTitle>
             <EuiText size="s" color="subdued">

diff --git a/public/pages/Detectors/containers/DetectorDetailsView/DetectorDetailsView.tsx b/public/pages/Detectors/containers/DetectorDetailsView/DetectorDetailsView.tsx
@@ -4,6 +4,7 @@
  */
 
 import React from 'react';
+import { EuiSpacer } from '@elastic/eui';
 import { DetectorBasicDetailsView } from '../../components/DetectorBasicDetailsView/DetectorBasicDetailsView';
 import { DetectorRulesView } from '../../components/DetectorRulesView/DetectorRulesView';
 import { RuleItem } from '../../../CreateDetector/components/DefineDetector/components/DetectionRules/types/interfaces';
@@ -68,7 +69,12 @@ export class DetectorDetailsView extends React.Component<
           {rulesCanFold ? detectorRules : null}
         </DetectorBasicDetailsView>
 
-        {rulesCanFold ? null : detectorRules}
+        {rulesCanFold ? null : (
+          <>
+            <EuiSpacer size={'m'} />
+            {detectorRules}
+          </>
+        )}
       </>
     );
   }

diff --git a/public/pages/Rules/components/RuleEditor/RuleEditorFormModel.ts b/public/pages/Rules/components/RuleEditor/RuleEditorFormModel.ts
@@ -28,7 +28,7 @@ export const ruleEditorStateDefaultValue: RuleEditorFormModel = {
   description: '',
   status: '',
   author: '',
-  references: [''],
+  references: [],
   tags: [],
   detection: '',
   level: '',