Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate Create/Update/Validate Detector using RestHighLevelClient #353

Closed
12 tasks done
Tracked by #5224
dbwiddis opened this issue Jan 21, 2023 · 1 comment
Closed
12 tasks done
Tracked by #5224
Assignees
Labels
enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jan 21, 2023

Is your feature request related to a problem?

This is a summary issue replacing validate detector #217 and all its sub-issues #221, #222, #223, #224, #225, and #226 and replaces Create Detector functionality of #58, and adds Update Detector functionality (not yet tracked in an issue).

All three of these implementations share the same set of parent classes in the AD Plugin, so implementing one would create a large diff with duplicate classes. By waiting to submit a PR until all are complete the existing classes can all be replaced, the diff will be smaller and much more understandable/useful to future migration efforts.

What solution would you like?

  • Migrate the RestIndexAnomalyDetectorAction which implements POST (Create) and PUT (Update) functionality
  • Complete Create Detector workflow
  • Complete Update Detector workflow
  • Migrate the RestValidateAnomalyDetectorAction which implements validate functionality
  • Complete Validate Detector Workflow
    • Some "dryRun" boolean code paths may not have been tested and will require further updates
    • There may be additional steps required for validate detector model which may be moved to a new issue
  • Replace existing classes with migrated versions of classes to minimize the diff
  • Create a MIGRATING.md document to help future migrators
  • Fix or bypass failing tests
    WIP is on this fork: https://github.com/dbwiddis/anomaly-detection/tree/rhlc
@dbwiddis dbwiddis added enhancement New feature or request untriaged labels Jan 21, 2023
@dbwiddis dbwiddis self-assigned this Jan 21, 2023
@dbwiddis
Copy link
Member Author

dbwiddis commented Feb 7, 2023

Completed in AD #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant