Create SDKRestClient wrapper class around RestHighLevelClient #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
CEHENKLE,
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #367 +/- ##
============================================
+ Coverage 69.35% 70.89% +1.53%
- Complexity 126 128 +2
============================================
Files 27 27
Lines 558 584 +26
Branches 15 15
============================================
+ Hits 387 414 +27
Misses 162 162
+ Partials 9 8 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Daniel Widdis <[email protected]>
owaiskazi19
previously approved these changes
Jan 28, 2023
There was a problem hiding this comment.
Minor nits. This wrapper class would definitely ease the migration for a plugin to an extension. Thanks @dbwiddis for this!
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
owaiskazi19
approved these changes
Jan 29, 2023
joshpalis
approved these changes
Jan 30, 2023
saratvemulapalli
approved these changes
Jan 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
* RestHighLevelClient Wrapper Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Add admin method returning the underlying SDKClient Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 6f26cae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan
pushed a commit
that referenced
this pull request
Feb 3, 2023
…408) * RestHighLevelClient Wrapper * Address code review comments * Add admin method returning the underlying SDKClient --------- (cherry picked from commit 6f26cae) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…arch-project#367) * RestHighLevelClient Wrapper Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Add admin method returning the underlying SDKClient Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis [email protected]
Description
Creates a wrapper class translating the
Clientclass method signatures toRestHighLevelClientmethods. Existing code making the various REST calls does not need to change (mostly) except for:Massively speeds the process of migrating existing plugins.
Notes:
Clientinterface, to minimize the (deprecated) footprint to what is necessaryIssues Resolved
Part of #353
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.