[Feature/extensions] Migrate Create, Update, and Validate actions to extension

[dbwiddis]

Description

Migrates the IndexAnomalyDetectorTransportAction, ValidateAnomalyDetectorTransportAction, their Rest Handlers, and other supporting classes from plugin to extension.

Testing requires adding a document to an index which requires working around #5999 locally.

See SDK #372 for a summary of the changes that you'll see in the diff.

Issues Resolved

Fixes SDK #353.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[minalsha]

just a small suggestion: is it possible to break this huge PR into small PRs for quic review?

[dbwiddis]

just a small suggestion: is it possible to break this huge PR into small PRs for quic review?

Unfortunately not without having a breaking change. However, there really aren't as many changes as you might think.

SDK #372 committed a migration guide which pretty much summarizes the diff here. I'll be a bit more specific if it helps. From top down on files:

• build.gradle: had to suppress some jacoco exclusions due to test coverage and add dependency on rest high level client
• ADExtension: add path to the new actions, and add getter for the rest client wrapper
• ADPlugin: (UNUSED, Reference) mostly whitespace changes, setting client and clusterservice to null in objects whose class types have changed
• Remaining classes mostly change Client to SDKRestClient, ClusterService to SDKClusterService, and change the imports for Request and Response objects. Exceptions follow:
  • Settings update consumers use a more efficient map approach
  • AnomalyDetectionIndices rollover request required new syntax for createRequest mapping and deleteIndex iteration
  • RestIndex and RestValidate DetectorActions are new format for extension rest actions, mostly self explanatory and indicated in migration doc
  • TransportActions doExecute made public
  • Test, a lot of things suppressed pending completion of createcomponents work next sprint

[codecov-commenter]

Codecov Report

Merging #792 (7f68dc7) into feature/extensions (1ba8bc6) will decrease coverage by 2.22%.
The diff coverage is 13.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                    @@
##             feature/extensions     #792      +/-   ##
========================================================
- Coverage                 53.23%   51.02%   -2.22%     
+ Complexity                 2661     2576      -85     
========================================================
  Files                       291      291              
  Lines                     16099    16110      +11     
  Branches                   1689     1685       -4     
========================================================
- Hits                       8571     8220     -351     
- Misses                     6911     7307     +396     
+ Partials                    617      583      -34     

Flag	Coverage Δ
plugin	51.02% <13.13%> (-2.22%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java	0.00% <0.00%> (ø)
.../java/org/opensearch/ad/AnomalyDetectorPlugin.java	86.56% <ø> (-0.20%)	⬇️
...nsearch/ad/rest/AbstractAnomalyDetectorAction.java	0.00% <0.00%> (-100.00%)	⬇️
...search/ad/rest/RestIndexAnomalyDetectorAction.java	0.00% <0.00%> (-25.72%)	⬇️
...rch/ad/rest/RestValidateAnomalyDetectorAction.java	0.00% <0.00%> (ø)
...est/handler/IndexAnomalyDetectorActionHandler.java	100.00% <ø> (ø)
.../ad/rest/handler/ModelValidationActionHandler.java	0.00% <ø> (ø)
.../handler/ValidateAnomalyDetectorActionHandler.java	100.00% <ø> (ø)
...ansport/PreviewAnomalyDetectorTransportAction.java	76.92% <ø> (ø)
...nsport/ValidateAnomalyDetectorTransportAction.java	0.00% <0.00%> (ø)
... and 23 more

[owaiskazi19]

Looks good overall with few changes and questions! Thanks for working on this @dbwiddis!

[owaiskazi19]

Can we move line 164-168 under sendAnomalyDetectorValidationParseResponse method?

[dbwiddis]

Uh, lines 164-168 are the replacement for sendAnomalyDetectorValidationParseResponse which should probably be deleted.

Unless by "under" you mean, change this to return sendAnomalyDetectorValidationParseResponse(issue) and move the 3 lines into that method? Sure.

[vibrantvarun]

Trying to understand why these many files are in jacoco exclusions?

[dbwiddis]

Trying to understand why these many files are in jacoco exclusions?

We've commented out a lot of the unit tests until the functionality is migrated. Goal is to re-enable them when migration is closer to complete (and we've uncommented/modified the tests)