Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement AD TransportGetFieldMappingsAction #361

Closed
dbwiddis opened this issue Jan 24, 2023 · 2 comments · Fixed by #672
Closed

[FEATURE] Implement AD TransportGetFieldMappingsAction #361

dbwiddis opened this issue Jan 24, 2023 · 2 comments · Fixed by #672
Assignees
Labels
enhancement New feature or request untriaged

Comments

@dbwiddis
Copy link
Member

Is your feature request related to a problem?

AbstractAnomalyDetectionActionHandler executes GetFieldMappingsAction twice (line 388 and 668) as part of field validation steps. The implementation involves cluster-level / shard-level actions that go beyond capabilities of the Rest client. These need to be investigated and implemented.

What solution would you like?

Update SDKClusterService to offer an API to accomplish the above.

@dbwiddis
Copy link
Member Author

dbwiddis commented May 2, 2023

Reopening this issue as while the request has been added to the SDKClient, it has not yet been implemented in the AD AbstractAnomalyDetectionActionHandler class. (CC: @joshpalis can you fix?)

@dbwiddis
Copy link
Member Author

dbwiddis commented May 2, 2023

https://github.com/opensearch-project/anomaly-detection/blob/697b9b7a50b5d1f22911135641180817fd06bf1d/src/main/java/org/opensearch/ad/rest/handler/AbstractAnomalyDetectorActionHandler.java#L384-L388

https://github.com/opensearch-project/anomaly-detection/blob/697b9b7a50b5d1f22911135641180817fd06bf1d/src/main/java/org/opensearch/ad/rest/handler/AbstractAnomalyDetectorActionHandler.java#L674-L678

In both cases the ActionListener has already been created, and would throw exceptions on failure if called, so it's mostly uncommenting out the client.execute() transport pieces, replacing with the new sdkClient REST call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants