Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create a Rest Handler to add POST _validate/detector method #221

Closed
dbwiddis opened this issue Nov 2, 2022 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Nov 2, 2022

Is your feature request related to a problem?

Similar to the Rest Handler created for Create Detector or Hello World Extension or GET method in #213, create an action implementing ExtensionRestHandler with routes for the validate detector API calls handled by appropriate methods with placeholder code:

POST /detectors/_validate
POST /detectors/_validate/{type}

Java code:

private ExtensionRestResponse handleValidateDetectorRequest(ExtensionRestRequest request) {
    // do things with request
    return new ExtensionRestResponse(request, OK, "placeholder");
}

Create a POST _validate Rest handler for validate detector similar to this. The business logic will be later done in #222.

@mloufra
Copy link
Contributor

mloufra commented Nov 15, 2022

  • Create RestValidateDetectorAction.java placed in AnomalyDetector repository feature/extensions branch
  • Add Route method
  • Add handleValidateDetectorRequest method
  • Add Post_Validate action to the list of Rest Handlers in the AnomalyDetectorExtension.java

@dbwiddis
Copy link
Member Author

I like the checkbox status comment!

@dbwiddis
Copy link
Member Author

Completed in AD #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants