-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved typings #3302
Improved typings #3302
Conversation
Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <[email protected]>
1ed6818
to
8396f9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djindjic Thanks for the contribution! This is the correct type usage we want.
The only suggestion I have is to rename both L174 and 188 from MyPluginDepsStart
to MyPluginStartDeps
, which is more conventional and would better match the other examples in this doc.
Signed-off-by: Josh Romero <[email protected]>
Thanks @djindjic ! |
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <[email protected]> * Nit - rename example deps prop Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit c35dadb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` * Nit - rename example deps prop --------- (cherry picked from commit c35dadb) Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Josh Romero <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]>
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <[email protected]> * Nit - rename example deps prop Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]> Signed-off-by: David Sinclair <[email protected]>
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <[email protected]> * Nit - rename example deps prop Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Description
With this PR on docs I would actually like to confirm if this is the proper way of typing plugin dependencies.
Passing this first param to
CoreSetup
generic would set a proper type todepsStart
returned fromcore.getStartServices()