-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create index pattern - modal popup #366
Create index pattern - modal popup #366
Conversation
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Screen.Recording.2023-01-19.at.7.52.44.PM.mov |
Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic Do you think we should hide the |
Signed-off-by: Aleksandar Djindjic <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 15.39% 15.33% -0.07%
==========================================
Files 109 111 +2
Lines 2890 2961 +71
Branches 476 488 +12
==========================================
+ Hits 445 454 +9
- Misses 2406 2468 +62
Partials 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
@amsiglan I was doubting on how to make a proper typing on injected dependencies. Seems like this is the right way: f883426 Now it is no more optional as service. Tests will cover it more I've also created opensearch-project/OpenSearch-Dashboards#3302 on Dashboards Core docs in order to confirm it with core team guys. |
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
0f9b540
to
0bfba74
Compare
* create index pattern modal Signed-off-by: Aleksandar Djindjic <[email protected]> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <[email protected]> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <[email protected]> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * rename props Signed-off-by: Aleksandar Djindjic <[email protected]> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <[email protected]> * typos and minor changes Signed-off-by: Aleksandar Djindjic <[email protected]> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <[email protected]> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <[email protected]> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <[email protected]> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2f08f22)
* create index pattern modal Signed-off-by: Aleksandar Djindjic <[email protected]> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <[email protected]> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <[email protected]> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * rename props Signed-off-by: Aleksandar Djindjic <[email protected]> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <[email protected]> * typos and minor changes Signed-off-by: Aleksandar Djindjic <[email protected]> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <[email protected]> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <[email protected]> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <[email protected]> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <[email protected]>
…ch-project#397) * create index pattern modal Signed-off-by: Aleksandar Djindjic <[email protected]> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <[email protected]> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <[email protected]> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * rename props Signed-off-by: Aleksandar Djindjic <[email protected]> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <[email protected]> * typos and minor changes Signed-off-by: Aleksandar Djindjic <[email protected]> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <[email protected]> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <[email protected]> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <[email protected]> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
…ch-project#397) * create index pattern modal Signed-off-by: Aleksandar Djindjic <[email protected]> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <[email protected]> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <[email protected]> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * rename props Signed-off-by: Aleksandar Djindjic <[email protected]> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <[email protected]> * typos and minor changes Signed-off-by: Aleksandar Djindjic <[email protected]> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <[email protected]> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <[email protected]> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <[email protected]> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
* create index pattern modal Signed-off-by: Aleksandar Djindjic <[email protected]> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <[email protected]> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <[email protected]> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <[email protected]> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * rename props Signed-off-by: Aleksandar Djindjic <[email protected]> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <[email protected]> * typos and minor changes Signed-off-by: Aleksandar Djindjic <[email protected]> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <[email protected]> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <[email protected]> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <[email protected]> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <[email protected]> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <[email protected]> --------- Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <[email protected]>
Description
In place index pattern creation on surrounding documents requested
Issues Resolved
Closes #132
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.