Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create index pattern - modal popup #366

Merged

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Jan 13, 2023

Description

In place index pattern creation on surrounding documents requested

Issues Resolved

Closes #132

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic djindjic requested a review from a team January 13, 2023 20:49
public/models/interfaces.ts Outdated Show resolved Hide resolved
@djindjic
Copy link
Contributor Author

@amsiglan

Screen.Recording.2023-01-19.at.7.52.44.PM.mov

@djindjic djindjic changed the title [WIP] create index pattern modal Create index pattern - modal popup Jan 19, 2023
Signed-off-by: Aleksandar Djindjic <[email protected]>
public/plugin.ts Outdated Show resolved Hide resolved
@amsiglan
Copy link
Collaborator

@djindjic Do you think we should hide the View surrounding documents button if the indexPatternService is not available or should it not be marked as optional?

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Merging #366 (5384c2e) into main (a03e697) will decrease coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   15.39%   15.33%   -0.07%     
==========================================
  Files         109      111       +2     
  Lines        2890     2961      +71     
  Branches      476      488      +12     
==========================================
+ Hits          445      454       +9     
- Misses       2406     2468      +62     
  Partials       39       39              
Impacted Files Coverage Δ
...ashboards-plugin/public/security_analytics_app.tsx 5.88% <0.00%> (-0.37%) ⬇️
...urity-analytics-dashboards-plugin/public/plugin.ts 0.00% <0.00%> (ø)
...ytics-dashboards-plugin/public/pages/Main/Main.tsx 8.88% <0.00%> (ø)
...ic/pages/Findings/containers/Findings/Findings.tsx 9.70% <0.00%> (ø)
...indings/components/FindingsTable/FindingsTable.tsx 18.75% <0.00%> (ø)
...ges/Findings/components/CreateIndexPatternForm.tsx 13.20% <0.00%> (ø)
...rds-plugin/public/services/IndexPatternsService.ts 0.00% <0.00%> (ø)
...pages/Findings/components/FindingDetailsFlyout.tsx 9.72% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic
Copy link
Contributor Author

djindjic commented Jan 22, 2023

@djindjic Do you think we should hide the View surrounding documents button if the indexPatternService is not available or should it not be marked as optional?

@amsiglan I was doubting on how to make a proper typing on injected dependencies. Seems like this is the right way: f883426

Now it is no more optional as service. Tests will cover it more

I've also created opensearch-project/OpenSearch-Dashboards#3302 on Dashboards Core docs in order to confirm it with core team guys.

@djindjic djindjic force-pushed the feature/create-index-pattern branch 2 times, most recently from 0f9b540 to 0bfba74 Compare January 26, 2023 11:56
@AWSHurneyt AWSHurneyt merged commit 2f08f22 into opensearch-project:main Jan 31, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2023
* create index pattern modal

Signed-off-by: Aleksandar Djindjic <[email protected]>

* validate index pattern name and fill timeFields

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse SavedObjectsService from dashboards core

Signed-off-by: Aleksandar Djindjic <[email protected]>

* take title and time field from the form

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse index patterns service from core dashboards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* improve ux for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename props

Signed-off-by: Aleksandar Djindjic <[email protected]>

* submit button loading state from formik submiting

Signed-off-by: Aleksandar Djindjic <[email protected]>

* typos and minor changes

Signed-off-by: Aleksandar Djindjic <[email protected]>

* indexPatternsService marked as mandatory dep

Signed-off-by: Aleksandar Djindjic <[email protected]>

* better typing on injected dependencies

Signed-off-by: Aleksandar Djindjic <[email protected]>

* cypress test for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* align cypress test with new convention

Signed-off-by: Aleksandar Djindjic <[email protected]>

* useCallback event handler wrapper

Signed-off-by: Aleksandar Djindjic <[email protected]>

---------

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 2f08f22)
amsiglan pushed a commit that referenced this pull request Jan 31, 2023
* create index pattern modal

Signed-off-by: Aleksandar Djindjic <[email protected]>

* validate index pattern name and fill timeFields

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse SavedObjectsService from dashboards core

Signed-off-by: Aleksandar Djindjic <[email protected]>

* take title and time field from the form

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse index patterns service from core dashboards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* improve ux for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename props

Signed-off-by: Aleksandar Djindjic <[email protected]>

* submit button loading state from formik submiting

Signed-off-by: Aleksandar Djindjic <[email protected]>

* typos and minor changes

Signed-off-by: Aleksandar Djindjic <[email protected]>

* indexPatternsService marked as mandatory dep

Signed-off-by: Aleksandar Djindjic <[email protected]>

* better typing on injected dependencies

Signed-off-by: Aleksandar Djindjic <[email protected]>

* cypress test for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* align cypress test with new convention

Signed-off-by: Aleksandar Djindjic <[email protected]>

* useCallback event handler wrapper

Signed-off-by: Aleksandar Djindjic <[email protected]>

---------

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 2f08f22)

Co-authored-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…ch-project#397)

* create index pattern modal

Signed-off-by: Aleksandar Djindjic <[email protected]>

* validate index pattern name and fill timeFields

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse SavedObjectsService from dashboards core

Signed-off-by: Aleksandar Djindjic <[email protected]>

* take title and time field from the form

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse index patterns service from core dashboards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* improve ux for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename props

Signed-off-by: Aleksandar Djindjic <[email protected]>

* submit button loading state from formik submiting

Signed-off-by: Aleksandar Djindjic <[email protected]>

* typos and minor changes

Signed-off-by: Aleksandar Djindjic <[email protected]>

* indexPatternsService marked as mandatory dep

Signed-off-by: Aleksandar Djindjic <[email protected]>

* better typing on injected dependencies

Signed-off-by: Aleksandar Djindjic <[email protected]>

* cypress test for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* align cypress test with new convention

Signed-off-by: Aleksandar Djindjic <[email protected]>

* useCallback event handler wrapper

Signed-off-by: Aleksandar Djindjic <[email protected]>

---------

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 2f08f22)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ch-project#397)

* create index pattern modal

Signed-off-by: Aleksandar Djindjic <[email protected]>

* validate index pattern name and fill timeFields

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse SavedObjectsService from dashboards core

Signed-off-by: Aleksandar Djindjic <[email protected]>

* take title and time field from the form

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse index patterns service from core dashboards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* improve ux for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename props

Signed-off-by: Aleksandar Djindjic <[email protected]>

* submit button loading state from formik submiting

Signed-off-by: Aleksandar Djindjic <[email protected]>

* typos and minor changes

Signed-off-by: Aleksandar Djindjic <[email protected]>

* indexPatternsService marked as mandatory dep

Signed-off-by: Aleksandar Djindjic <[email protected]>

* better typing on injected dependencies

Signed-off-by: Aleksandar Djindjic <[email protected]>

* cypress test for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* align cypress test with new convention

Signed-off-by: Aleksandar Djindjic <[email protected]>

* useCallback event handler wrapper

Signed-off-by: Aleksandar Djindjic <[email protected]>

---------

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 2f08f22)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this pull request Mar 16, 2024
* create index pattern modal

Signed-off-by: Aleksandar Djindjic <[email protected]>

* validate index pattern name and fill timeFields

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse SavedObjectsService from dashboards core

Signed-off-by: Aleksandar Djindjic <[email protected]>

* take title and time field from the form

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reuse index patterns service from core dashboards

Signed-off-by: Aleksandar Djindjic <[email protected]>

* improve ux for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rename props

Signed-off-by: Aleksandar Djindjic <[email protected]>

* submit button loading state from formik submiting

Signed-off-by: Aleksandar Djindjic <[email protected]>

* typos and minor changes

Signed-off-by: Aleksandar Djindjic <[email protected]>

* indexPatternsService marked as mandatory dep

Signed-off-by: Aleksandar Djindjic <[email protected]>

* better typing on injected dependencies

Signed-off-by: Aleksandar Djindjic <[email protected]>

* cypress test for create index pattern

Signed-off-by: Aleksandar Djindjic <[email protected]>

* align cypress test with new convention

Signed-off-by: Aleksandar Djindjic <[email protected]>

* useCallback event handler wrapper

Signed-off-by: Aleksandar Djindjic <[email protected]>

---------

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 2f08f22)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Integration with the discover plugin
4 participants