Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of IndexPatternsService in Opensearch Dashboards plugins #3280

Closed
djindjic opened this issue Jan 17, 2023 · 3 comments
Closed

Reuse of IndexPatternsService in Opensearch Dashboards plugins #3280

djindjic opened this issue Jan 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@djindjic
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As part of one new feature in Security Analytics plugin, we would need to reuse IndexPatternsService. Does it make sense to share it via CoreStart in the same way as you share notifications service and we can access it in straightforward way via plugin setup method?

cc: @amsiglan @AWSHurneyt

@djindjic djindjic added the enhancement New feature or request label Jan 17, 2023
@manasvinibs
Copy link
Member

Yes, that seems to be the preferred way to do that. If you have more questions while developing it, please post here and reach out the team.

@manasvinibs
Copy link
Member

@djindjic
Copy link
Contributor Author

@manasvinibs thanks a lot on you points.

We have just done it as it's defined in docs. Just as a final confirmation I have proposed docs improvement that I realized while wanted to improve some typings on our side. Please check if it make sense: #3302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants