Skip to content

Commit

Permalink
Improved typings
Browse files Browse the repository at this point in the history
Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()`

Signed-off-by: Aleksandar Djindjic <[email protected]>
  • Loading branch information
djindjic committed Jan 22, 2023
1 parent 52769f2 commit 8396f9d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/CONVENTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,10 @@ export const renderApp = (
```ts
// my_plugin/public/plugin.ts

import { Plugin } from '../../src/core/public';
import { Plugin, CoreSetup } from '../../src/core/public';

export class MyPlugin implements Plugin {
public setup(core) {
public setup(core: CoreSetup<MyPluginDepsStart>) {
core.application.register({
id: 'my-app',
async mount(params) {
Expand Down

0 comments on commit 8396f9d

Please sign in to comment.