Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to allow Functional tests to run #236

Merged
merged 7 commits into from
Apr 5, 2021
Merged

Updates to allow Functional tests to run #236

merged 7 commits into from
Apr 5, 2021

Conversation

boktorbb
Copy link
Contributor

Fixed named references and switched default ftr run mode to source

Signed-off-by: Bishoy Boktor [email protected]

@boktorbb boktorbb added this to the Beta release milestone Mar 29, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed 07f5eeb

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Mar 29, 2021

start dco dashboards since we changed the job name

@odfe-release-bot
Copy link

✅   DCO Check Passed 07f5eeb

scripts/opensearch.js Outdated Show resolved Hide resolved
@odfe-release-bot
Copy link

✅   DCO Check Passed ae5d795

@odfe-release-bot
Copy link

✅   DCO Check Passed 1c80531

@odfe-release-bot
Copy link

✅   DCO Check Passed 961b276

kavilla
kavilla previously requested changes Apr 2, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise and functionally looks good to me but can you update packages/osd-opensearch/src/artifact.test.js it's failing the unit tests.

@boktorbb boktorbb requested a review from kavilla April 2, 2021 22:41
@boktorbb boktorbb dismissed kavilla’s stale review April 2, 2021 22:42

Updated the unit tests

@odfe-release-bot
Copy link

✅   DCO Check Passed 8bf9375

kavilla
kavilla previously approved these changes Apr 2, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mihirsoni
mihirsoni previously approved these changes Apr 3, 2021
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Just one small comment !!

Bishoy Boktor added 6 commits April 5, 2021 17:34
updated README with download and setup instructions for both OpenSearch
and Dashboards.

Closes #223

Signed-off-by: Bishoy Boktor <[email protected]>
Fixed named references and switched default ftr run mode to source

Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
Removed the check for the self-created extraction directory and removed
the no-longer existing security check arg

Signed-off-by: Bishoy Boktor <[email protected]>
Test Suites: 23 skipped, 1412 passed, 1412 of 1435 total
Tests:       256 skipped, 9 todo, 10342 passed, 10607 total
Snapshots:   2363 passed, 2363 total
Time:        42.427 s, estimated 43 s

Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
@boktorbb boktorbb dismissed stale reviews from mihirsoni and kavilla via 93e4276 April 5, 2021 17:35
@odfe-release-bot
Copy link

✅   DCO Check Passed 93e4276

@boktorbb boktorbb merged commit 6d11738 into opensearch-project:main Apr 5, 2021
boktorbb added a commit that referenced this pull request Apr 5, 2021
* Update README with instructions for running with OpenSearch

updated README with download and setup instructions for both OpenSearch
and Dashboards.

Closes #223

Signed-off-by: Bishoy Boktor <[email protected]>

* Updates to allow Functional tests to run

Fixed named references and switched default ftr run mode to source

Signed-off-by: Bishoy Boktor <[email protected]>

* Address PR comments

Signed-off-by: Bishoy Boktor <[email protected]>

* Address PR comments

Signed-off-by: Bishoy Boktor <[email protected]>

* Remove OPENSEARCH_TMPDIR check and security check from ftr run

Removed the check for the self-created extraction directory and removed
the no-longer existing security check arg

Signed-off-by: Bishoy Boktor <[email protected]>

* Update artifact unit tests

Test Suites: 23 skipped, 1412 passed, 1412 of 1435 total
Tests:       256 skipped, 9 todo, 10342 passed, 10607 total
Snapshots:   2363 passed, 2363 total
Time:        42.427 s, estimated 43 s

Signed-off-by: Bishoy Boktor <[email protected]>

* Address PR comments

Signed-off-by: Bishoy Boktor <[email protected]>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 23, 2023
…pensearch-project#236)

* feat: create management / public workspaces when calling list api

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix bootstrap

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: flaky test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 8ff9e88)
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 24, 2023
…pensearch-project#236)

* feat: create management / public workspaces when calling list api

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix bootstrap

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: flaky test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Feb 22, 2024
…pensearch-project#236)

* feat: create management / public workspaces when calling list api

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix bootstrap

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: flaky test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
…pensearch-project#236)

* feat: create management / public workspaces when calling list api

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix bootstrap

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: flaky test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants