-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to allow Functional tests to run #236
Conversation
✅ DCO Check Passed 07f5eeb |
start dco dashboards since we changed the job name |
✅ DCO Check Passed 07f5eeb |
packages/osd-test/src/legacy_opensearch/legacy_opensearch_test_cluster.js
Outdated
Show resolved
Hide resolved
packages/osd-test/src/legacy_opensearch/legacy_opensearch_test_cluster.js
Outdated
Show resolved
Hide resolved
✅ DCO Check Passed ae5d795 |
✅ DCO Check Passed 1c80531 |
✅ DCO Check Passed 961b276 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise and functionally looks good to me but can you update packages/osd-opensearch/src/artifact.test.js
it's failing the unit tests.
✅ DCO Check Passed 8bf9375 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
packages/osd-test/src/legacy_opensearch/legacy_opensearch_test_cluster.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Just one small comment !!
updated README with download and setup instructions for both OpenSearch and Dashboards. Closes #223 Signed-off-by: Bishoy Boktor <[email protected]>
Fixed named references and switched default ftr run mode to source Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
Removed the check for the self-created extraction directory and removed the no-longer existing security check arg Signed-off-by: Bishoy Boktor <[email protected]>
Test Suites: 23 skipped, 1412 passed, 1412 of 1435 total Tests: 256 skipped, 9 todo, 10342 passed, 10607 total Snapshots: 2363 passed, 2363 total Time: 42.427 s, estimated 43 s Signed-off-by: Bishoy Boktor <[email protected]>
Signed-off-by: Bishoy Boktor <[email protected]>
✅ DCO Check Passed 93e4276 |
* Update README with instructions for running with OpenSearch updated README with download and setup instructions for both OpenSearch and Dashboards. Closes #223 Signed-off-by: Bishoy Boktor <[email protected]> * Updates to allow Functional tests to run Fixed named references and switched default ftr run mode to source Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Remove OPENSEARCH_TMPDIR check and security check from ftr run Removed the check for the self-created extraction directory and removed the no-longer existing security check arg Signed-off-by: Bishoy Boktor <[email protected]> * Update artifact unit tests Test Suites: 23 skipped, 1412 passed, 1412 of 1435 total Tests: 256 skipped, 9 todo, 10342 passed, 10607 total Snapshots: 2363 passed, 2363 total Time: 42.427 s, estimated 43 s Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
…pensearch-project#236) * feat: create management / public workspaces when calling list api Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix bootstrap Signed-off-by: SuZhou-Joe <[email protected]> * fix: integration test Signed-off-by: SuZhou-Joe <[email protected]> * fix: flaky test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 8ff9e88)
…pensearch-project#236) * feat: create management / public workspaces when calling list api Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix bootstrap Signed-off-by: SuZhou-Joe <[email protected]> * fix: integration test Signed-off-by: SuZhou-Joe <[email protected]> * fix: flaky test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
…pensearch-project#236) * feat: create management / public workspaces when calling list api Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix bootstrap Signed-off-by: SuZhou-Joe <[email protected]> * fix: integration test Signed-off-by: SuZhou-Joe <[email protected]> * fix: flaky test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
…pensearch-project#236) * feat: create management / public workspaces when calling list api Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix bootstrap Signed-off-by: SuZhou-Joe <[email protected]> * fix: integration test Signed-off-by: SuZhou-Joe <[email protected]> * fix: flaky test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Fixed named references and switched default ftr run mode to source
Signed-off-by: Bishoy Boktor [email protected]