Address PR comments

Signed-off-by: Bishoy Boktor <[email protected]>
opensearch-project · Apr 2, 2021 · ae5d795 · ae5d795
1 parent fdf404f
commit ae5d795
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/packages/osd-opensearch/src/artifact.js b/packages/osd-opensearch/src/artifact.js
@@ -28,9 +28,7 @@ const path = require('path');
 
 const asyncPipeline = promisify(pipeline);
 const DAILY_SNAPSHOTS_BASE_URL = '';
-//'https://storage.googleapis.com/opensearch-dashboards-ci-opensearch-snapshots-daily';
 const PERMANENT_SNAPSHOTS_BASE_URL = '';
-//'https://storage.googleapis.com/opensearch-dashboards-ci-opensearch-snapshots-permanent';
 
 const { cache } = require('./utils');
 const { resolveCustomSnapshotUrl } = require('./custom_snapshots');

diff --git a/packages/osd-test/src/functional_tests/lib/run_opensearch.js b/packages/osd-test/src/functional_tests/lib/run_opensearch.js
@@ -57,7 +57,7 @@ export async function runOpenSearch({ config, options }) {
       : config.get('servers.opensearch.password'),
     license,
     log,
-    basePath: resolve(OPENSEARCH_DASHBOARDS_ROOT, '../OpenSearch'),
+    basePath: resolve(OPENSEARCH_DASHBOARDS_ROOT, '.opensearch'),
     opensearchFrom: opensearchFrom || config.get('opensearchTestCluster.from'),
     dataArchive: config.get('opensearchTestCluster.dataArchive'),
     opensearchArgs,

diff --git a/packages/osd-test/src/legacy_opensearch/legacy_opensearch_test_cluster.js b/packages/osd-test/src/legacy_opensearch/legacy_opensearch_test_cluster.js
@@ -58,7 +58,7 @@ export function createLegacyOpenSearchTestCluster(options = {}) {
   const config = {
     version: opensearchTestConfig.getVersion(),
     installPath: resolve(basePath, clusterName),
-    sourcePath: resolve(OPENSEARCH_DASHBOARDS_ROOT, '../OpenSearch'),
+    sourcePath: resolve(OPENSEARCH_DASHBOARDS_ROOT, '.opensearch'),
     password,
     license,
     basePath,
@@ -78,7 +78,6 @@ export function createLegacyOpenSearchTestCluster(options = {}) {
     async start() {
       let installPath;
 
-      console.log('I"M RUNNING WOOO');
       if (opensearchFrom === 'source') {
         installPath = (await cluster.installSource(config)).installPath;
       } else if (opensearchFrom === 'snapshot') {

diff --git a/scripts/opensearch.js b/scripts/opensearch.js
@@ -28,8 +28,8 @@ osdOpenSearch
     license: 'oss',
     password: 'changeme',
     version: pkg.version,
-    'source-path': resolve(__dirname, '../../OpenSearch'),
-    'base-path': resolve(__dirname, '../../OpenSearch'),
+    'source-path': resolve(__dirname, '../../opensearch'),
+    'base-path': resolve(__dirname, '../.opensearch'),
     ssl: false,
   })
   .catch(function (e) {