Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to allow Functional tests to run #236

Merged
merged 7 commits into from
Apr 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,4 @@ As we've been working, we've come up with a bunch of questions that we wanted to

### Questions? Feedback?

Let us know in the [forums](https://discuss.opendistrocommunity.dev/). w00t!!!
Let us know in the [forums](https://discuss.opendistrocommunity.dev/). w00t!!!
6 changes: 2 additions & 4 deletions packages/osd-opensearch/src/artifact.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ const { createHash } = require('crypto');
const path = require('path');

const asyncPipeline = promisify(pipeline);
const DAILY_SNAPSHOTS_BASE_URL =
'https://storage.googleapis.com/opensearch-dashboards-ci-opensearch-snapshots-daily';
const PERMANENT_SNAPSHOTS_BASE_URL =
'https://storage.googleapis.com/opensearch-dashboards-ci-opensearch-snapshots-permanent';
const DAILY_SNAPSHOTS_BASE_URL = '';
const PERMANENT_SNAPSHOTS_BASE_URL = '';

const { cache } = require('./utils');
const { resolveCustomSnapshotUrl } = require('./custom_snapshots');
Expand Down
6 changes: 2 additions & 4 deletions packages/osd-opensearch/src/artifact.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ const MOCK_VERSION = 'test-version';
const MOCK_URL = 'http://127.0.0.1:12345';
const MOCK_FILENAME = 'test-filename';

const DAILY_SNAPSHOT_BASE_URL =
'https://storage.googleapis.com/opensearch-dashboards-ci-opensearch-snapshots-daily';
const PERMANENT_SNAPSHOT_BASE_URL =
'https://storage.googleapis.com/opensearch-dashboards-ci-opensearch-snapshots-permanent';
const DAILY_SNAPSHOT_BASE_URL = '';
const PERMANENT_SNAPSHOT_BASE_URL = '';

const createArchive = (params = {}) => {
const license = params.license || 'default';
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-opensearch/src/cli_commands/source.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const { Cluster } = require('../cluster');
exports.description = 'Build and run from source';

exports.help = (defaults = {}) => {
const { license = 'basic', password = 'changeme', 'base-path': basePath } = defaults;
const { license = 'oss', password = 'changeme', 'base-path': basePath } = defaults;

return dedent`
Options:
Expand Down
6 changes: 3 additions & 3 deletions packages/osd-opensearch/src/cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,9 @@ exports.Cluster = class Cluster {
this._process = execa(OPENSEARCH_BIN, args, {
cwd: installPath,
env: {
...(installPath
? { OPENSEARCH_TMPDIR: path.resolve(installPath, 'OPENSEARCH_TMPDIR') }
: {}),
//...(installPath
//? { OPENSEARCH_TMPDIR: path.resolve(installPath, 'OPENSEARCH_TMPDIR') }
//: {}),
...process.env,
...(options.bundledJDK ? { JAVA_HOME: '' } : {}),
...(options.opensearchEnvVars || {}),
Expand Down
Empty file removed plugins/.empty
Empty file.
2 changes: 1 addition & 1 deletion scripts/opensearch.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var osdOpenSearch = require('@osd/opensearch');

osdOpenSearch
.run({
license: 'basic',
license: 'oss',
password: 'changeme',
version: pkg.version,
'source-path': resolve(__dirname, '../../opensearch'),
Expand Down
2 changes: 1 addition & 1 deletion test/common/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function () {
`--home.disableWelcomeScreen=true`,
// Needed for async search functional tests to introduce a delay
`--data.search.aggs.shardDelay.enabled=true`,
`--security.showInsecureClusterWarning=false`,
//`--security.showInsecureClusterWarning=false`,
// '--telemetry.banner=false',
// '--telemetry.optIn=false',
// These are *very* important to have them pointing to staging
Expand Down
6 changes: 3 additions & 3 deletions test/common/services/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@

import { DeploymentProvider } from './deployment';
import { LegacyOpenSearchProvider } from './legacy_opensearch';
import { OpenSearchearchProvider } from './opensearch';
import { OpenSearchProvider } from './opensearch';
import { OpenSearchArchiverProvider } from './opensearch_archiver';
import { OpenSearchDashboardsServerProvider } from './opensearch_dasboards_server';
import { OpenSearchDashboardsServerProvider } from './opensearch_dashboards_server';
import { RetryProvider } from './retry';
import { RandomnessProvider } from './randomness';
import { SecurityServiceProvider } from './security';

export const services = {
deployment: DeploymentProvider,
legacyOpenSearch: LegacyOpenSearchProvider,
opensearch: OpenSearchearchProvider,
opensearch: OpenSearchProvider,
opensearchArchiver: OpenSearchArchiverProvider,
opensearchDashboardsServer: OpenSearchDashboardsServerProvider,
retry: RetryProvider,
Expand Down
2 changes: 1 addition & 1 deletion test/common/services/opensearch_archiver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { OpenSearchArchiver } from '@osd/opensearch-archiver';
import { FtrProviderContext } from '../ftr_provider_context';

// @ts-ignore not TS yet
import * as OpenSearchDashboardsServer from './opensearch_dasboards_server';
import * as OpenSearchDashboardsServer from './opensearch_dashboards_server';

export function OpenSearchArchiverProvider({
getService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
* under the License.
*/

export { OpenSearchDashboardsServerProvider } from './opensearch_dasboards_server';
export { OpenSearchDashboardsServerProvider } from './opensearch_dashboards_server';
// @ts-ignore
export { extendOpenSearchArchiver } from './extend_opensearch_archiver';
2 changes: 1 addition & 1 deletion test/security_functional/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
...functionalConfig
.get('osdTestServer.serverArgs')
.filter((arg: string) => !arg.startsWith('--security.showInsecureClusterWarning')),
'--security.showInsecureClusterWarning=true',
// '--security.showInsecureClusterWarning=true',
// Required to load new platform plugins via `--plugin-path` flag.
'--env.name=development',
],
Expand Down