Skip to content

Commit

Permalink
Remove OPENSEARCH_TMPDIR check and security check from ftr run
Browse files Browse the repository at this point in the history
Removed the check for the self-created extraction directory and removed
the no-longer existing security check arg

Signed-off-by: Bishoy Boktor <[email protected]>
  • Loading branch information
Bishoy Boktor committed Apr 2, 2021
1 parent 1c80531 commit 961b276
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions packages/osd-opensearch/src/cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,9 @@ exports.Cluster = class Cluster {
this._process = execa(OPENSEARCH_BIN, args, {
cwd: installPath,
env: {
...(installPath
? { OPENSEARCH_TMPDIR: path.resolve(installPath, 'OPENSEARCH_TMPDIR') }
: {}),
//...(installPath
//? { OPENSEARCH_TMPDIR: path.resolve(installPath, 'OPENSEARCH_TMPDIR') }
//: {}),
...process.env,
...(options.bundledJDK ? { JAVA_HOME: '' } : {}),
...(options.opensearchEnvVars || {}),
Expand Down
2 changes: 1 addition & 1 deletion test/common/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function () {
`--home.disableWelcomeScreen=true`,
// Needed for async search functional tests to introduce a delay
`--data.search.aggs.shardDelay.enabled=true`,
`--security.showInsecureClusterWarning=false`,
//`--security.showInsecureClusterWarning=false`,
// '--telemetry.banner=false',
// '--telemetry.optIn=false',
// These are *very* important to have them pointing to staging
Expand Down
2 changes: 1 addition & 1 deletion test/security_functional/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
...functionalConfig
.get('osdTestServer.serverArgs')
.filter((arg: string) => !arg.startsWith('--security.showInsecureClusterWarning')),
'--security.showInsecureClusterWarning=true',
// '--security.showInsecureClusterWarning=true',
// Required to load new platform plugins via `--plugin-path` flag.
'--env.name=development',
],
Expand Down

0 comments on commit 961b276

Please sign in to comment.