Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src/fixtures,setup node env,test utils #141

Merged
merged 5 commits into from
Mar 11, 2021
Merged

Src/fixtures,setup node env,test utils #141

merged 5 commits into from
Mar 11, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #37

Description of changes: Src/fixtures,setup node env,test utils

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but otherwise looks good

src/setup_node_env/node_version_validator.js Outdated Show resolved Hide resolved
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a variable needs change.

src/setup_node_env/node_version_validator.js Outdated Show resolved Hide resolved
src/apm.js Show resolved Hide resolved
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kavilla kavilla merged commit 85714f7 into opensearch-project:dashboards Mar 11, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] src/fixtures directory

* [Rename] src/setup_node_env directory

* [Rename] src/test_utils directory

* [Rename] src/apm.js

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <[email protected]>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] src/fixtures directory

* [Rename] src/setup_node_env directory

* [Rename] src/test_utils directory

* [Rename] src/apm.js

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <[email protected]>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] src/fixtures directory

* [Rename] src/setup_node_env directory

* [Rename] src/test_utils directory

* [Rename] src/apm.js

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…nsearch-project#141)

* fix: workspace permission entire update



* refactor: rename to convertToFullWorkspacePermissions and remove read and write permission



* Revert "refactor: rename to convertToFullWorkspacePermissions and remove read and write permission"

This reverts commit a4b7ba7.



* Revert "fix: workspace permission entire update"

This reverts commit d972e13.



* fix: update to client.create to override entire object



* feat: add workspace version limit for object update



---------


(cherry picked from commit 0bd03df)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants